Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: bump hamcrest dep version and artifactId #136

Merged
merged 5 commits into from Jan 29, 2020
Merged

deps: bump hamcrest dep version and artifactId #136

merged 5 commits into from Jan 29, 2020

Commits on Jan 29, 2020

  1. deps: bump hamcrest dep version and artifactId 

    address build error: https://source.cloud.google.com/results/invocations/146b9fcc-cf53-41f1-a52e-e6ff1f857b2e/targets/cloud-devrel%2Fclient-libraries%2Fjava%2Fjava-bigquery%2Fpresubmit%2Fdependencies/log

[WARNING] Used undeclared dependencies found:
[WARNING]    org.hamcrest:hamcrest:jar:2.2:test
[WARNING] Unused declared dependencies found:
[WARNING]    org.hamcrest:hamcrest-core:jar:2.2:test
    @stephaniewang526
    stephaniewang526 committed Jan 29, 2020
    Copy the full SHA
    3e29c0e View commit details
    Browse the repository at this point in the history

  2. declaring hamcrest-core too to fix build error 

    build error: https://source.cloud.google.com/results/invocations/47658b43-45f4-436e-baa7-7f709f5f3863/targets/cloud-devrel%2Fclient-libraries%2Fjava%2Fjava-bigquery%2Fpresubmit%2Fdependencies/log

[WARNING] Used undeclared dependencies found:
[WARNING]    org.hamcrest:hamcrest-core:jar:1.3:test
[WARNING] Unused declared dependencies found:
[WARNING]    org.hamcrest:hamcrest:jar:2.2:test
    @stephaniewang526
    stephaniewang526 committed Jan 29, 2020
    Copy the full SHA
    5eceb33 View commit details
    Browse the repository at this point in the history

  3. removing hamcrest-core, again since build error re-occurred saying it… 

    …'s unused

https://source.cloud.google.com/results/invocations/c11a77e3-59fc-49e2-ae8b-4e10f4d968d4/targets/cloud-devrel%2Fclient-libraries%2Fjava%2Fjava-bigquery%2Fpresubmit%2Fdependencies/log

[WARNING] Unused declared dependencies found:
[WARNING]    org.hamcrest:hamcrest-core:jar:2.2:test
    @stephaniewang526
    stephaniewang526 committed Jan 29, 2020
    Copy the full SHA
    c75f90c View commit details
    Browse the repository at this point in the history

  4. move hamcrest to be above junit to fix build error

    @stephaniewang526
    stephaniewang526 committed Jan 29, 2020
    Copy the full SHA
    f6f1cd8 View commit details
    Browse the repository at this point in the history

  5. remove hamcrest-core since it's claimed as unused in build

    @stephaniewang526
    stephaniewang526 committed Jan 29, 2020
    Copy the full SHA
    3e5b156 View commit details
    Browse the repository at this point in the history