Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add debug statement to StandardTableDefinition #128

Merged
merged 8 commits into from Jan 28, 2020
Merged

feat: add debug statement to StandardTableDefinition #128

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
32245c7
chore: add debug statement to StandardTableDefinition
stephaniewang526 Jan 27, 2020
683220e
update to include cause
stephaniewang526 Jan 27, 2020
7f18fb1
remove changes to method headers
stephaniewang526 Jan 27, 2020
a1441c0
update base on comment
stephaniewang526 Jan 27, 2020
c3aeac4
adding testcase
stephaniewang526 Jan 28, 2020
0215d2c
adding testcases
stephaniewang526 Jan 28, 2020
b901f96
fix test dep build error
stephaniewang526 Jan 28, 2020
b1f0c8c
update to add more info
stephaniewang526 Jan 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
23 changes: 22 additions & 1 deletion google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/StandardTableDefinition.java
View file
Open in desktop
Expand Up @@ -272,7 +272,28 @@ static StandardTableDefinition fromPb(Table tablePb) {
builder.setStreamingBuffer(StreamingBuffer.fromPb(tablePb.getStreamingBuffer()));
}
if (tablePb.getTimePartitioning() != null) {
builder.setTimePartitioning(TimePartitioning.fromPb(tablePb.getTimePartitioning()));
try {
builder.setTimePartitioning(TimePartitioning.fromPb(tablePb.getTimePartitioning()));
} catch (IllegalArgumentException e) {
throw new IllegalArgumentException(
"Got unexpected time partitioning "
+ tablePb.getTimePartitioning()
+ " in table "
+ tablePb.getTableReference(),
e);
} catch (NullPointerException e) {
try {
throw new NullPointerException(
"Got unexpected time partitioning "
+ tablePb.getTimePartitioning()
+ " in table "
+ tablePb.getTableReference())
.initCause(e);
// catching Throwable due to adding initCause
} catch (Throwable throwable) {
throwable.printStackTrace();
stephaniewang526 marked this conversation as resolved.
Show resolved Hide resolved
}
}
}
if (tablePb.getRangePartitioning() != null) {
builder.setRangePartitioning(RangePartitioning.fromPb(tablePb.getRangePartitioning()));
Expand Down
13 changes: 13 additions & 0 deletions ...e-cloud-bigquery/src/test/java/com/google/cloud/bigquery/StandardTableDefinitionTest.java
View file
Open in desktop
Expand Up @@ -64,6 +64,13 @@ public class StandardTableDefinitionTest {
.setClustering(CLUSTERING)
.build();

// to test invalid time partitioning type set in table definition
private static final StandardTableDefinition INVALID_TABLE_DEFINITION =
StandardTableDefinition.newBuilder()
.setSchema(TABLE_SCHEMA)
.setTimePartitioning(null)
.build();

@Test
public void testToBuilder() {
compareStandardTableDefinition(TABLE_DEFINITION, TABLE_DEFINITION.toBuilder().build());
Expand Down Expand Up @@ -118,6 +125,12 @@ public void testToAndFromPb() {
definition, TableDefinition.<StandardTableDefinition>fromPb(definition.toPb()));
}

@Test(expected = IllegalArgumentException.class)
public void testInvalidTableDef() {
// not supposed to have this time partitioning type
StandardTableDefinition.fromPb(INVALID_TABLE_DEFINITION.toPb());
}

stephaniewang526 marked this conversation as resolved.
Show resolved Hide resolved
@Test
public void testFromPbWithNullEstimatedRowsAndBytes() {
StandardTableDefinition.fromPb(
Expand Down