Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(samples): add query with name types parameters #633

Merged
merged 1 commit into from Aug 3, 2020
Merged

docs(samples): add query with name types parameters #633

merged 1 commit into from Aug 3, 2020

Conversation

pmakani
Copy link
Contributor

@pmakani pmakani commented Aug 3, 2020

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@pmakani pmakani requested review from stephaniewang526 and a team August 3, 2020 12:42
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 3, 2020
@codecov
Copy link

codecov bot commented Aug 3, 2020 •
edited

Codecov Report

Merging #633 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #633   +/-   ##
=========================================
  Coverage     81.49%   81.49%           
  Complexity     1226     1226           
=========================================
  Files            77       77           
  Lines          6220     6220           
  Branches        691      691           
=========================================
  Hits           5069     5069           
  Misses          792      792           
  Partials        359      359

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 108e462...49ad99e. Read the comment docs.

@stephaniewang526 stephaniewang526 merged commit 082f1a2 into googleapis:master Aug 3, 2020
@pmakani pmakani deleted the query-params-named-types branch August 4, 2020 11:02
suraj-qlogic pushed a commit to suraj-qlogic/java-bigquery that referenced this pull request Aug 27, 2020
@yoshi-automation
ci(java): run dependency test on Java 8 and 11 (googleapis#474)
43d369f 
* changes without context

        autosynth cannot find the source of changes triggered by earlier changes in this
        repository, or by version upgrades to tools such as linters.

* ci(java): run dependency test on Java 8 and 11

Redo fix in googleapis#633 with proper jinja templating format

Source-Author: Jeff Ching <chingor@google.com>
Source-Date: Fri Jun 19 16:52:15 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: 4f2c9f752a94042472fc03c5bd9e06e89817d2bd
Source-Link: googleapis/synthtool@4f2c9f7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephaniewang526 stephaniewang526 stephaniewang526 approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pmakani @stephaniewang526