chore: fix assorted warnings (#74)

* fix assorted warnings * chore: fix assorted warnings * chore: reformat code Co-authored-by: Stephanie Wang <stephaniewang526@users.noreply.github.com>
googleapis · Jan 3, 2020 · e8016c1 · e8016c1
1 parent e967e10
commit e8016c1
Show file tree

Hide file tree

Showing 6 changed files with 9 additions and 7 deletions.
diff --git a/google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/Acl.java b/google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/Acl.java
@@ -56,7 +56,8 @@ public Role apply(String constant) {
           }
         };
 
-    private static final StringEnumType<Role> type = new StringEnumType(Role.class, CONSTRUCTOR);
+    private static final StringEnumType<Role> type =
+        new StringEnumType<Role>(Role.class, CONSTRUCTOR);
 
     /** Can read, query, copy or export tables in the dataset. */
     public static final Role READER = type.createAndRegister("READER");

diff --git a/google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/JobStatistics.java b/google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/JobStatistics.java
@@ -21,7 +21,6 @@
 import com.google.api.services.bigquery.model.JobStatistics2;
 import com.google.api.services.bigquery.model.JobStatistics3;
 import com.google.api.services.bigquery.model.JobStatistics4;
-import com.google.api.services.bigquery.model.ScriptStackFrame;
 import com.google.cloud.StringEnumType;
 import com.google.cloud.StringEnumValue;
 import com.google.common.base.Function;
@@ -352,7 +351,7 @@ public StatementType apply(String constant) {
           };
 
       private static final StringEnumType<StatementType> type =
-          new StringEnumType(StatementType.class, CONSTRUCTOR);
+          new StringEnumType<StatementType>(StatementType.class, CONSTRUCTOR);
 
       public static final StatementType SELECT = type.createAndRegister("SELECT");
       public static final StatementType UPDATE = type.createAndRegister("UPDATE");

diff --git a/google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/JobStatus.java b/google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/JobStatus.java
@@ -47,7 +47,8 @@ public State apply(String constant) {
           }
         };
 
-    private static final StringEnumType<State> type = new StringEnumType(State.class, CONSTRUCTOR);
+    private static final StringEnumType<State> type =
+        new StringEnumType<State>(State.class, CONSTRUCTOR);
 
     /** The BigQuery Job is waiting to be executed. */
     public static final State PENDING = type.createAndRegister("PENDING");

diff --git a/google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/LegacySQLTypeName.java b/google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/LegacySQLTypeName.java
@@ -41,7 +41,7 @@ public LegacySQLTypeName apply(String constant) {
       };
 
   private static final StringEnumType<LegacySQLTypeName> type =
-      new StringEnumType(LegacySQLTypeName.class, CONSTRUCTOR);
+      new StringEnumType<LegacySQLTypeName>(LegacySQLTypeName.class, CONSTRUCTOR);
 
   /** Variable-length binary data. */
   public static final LegacySQLTypeName BYTES =

diff --git a/google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/TableDefinition.java b/google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/TableDefinition.java
@@ -40,7 +40,8 @@ public Type apply(String constant) {
           }
         };
 
-    private static final StringEnumType<Type> type = new StringEnumType(Type.class, CONSTRUCTOR);
+    private static final StringEnumType<Type> type =
+        new StringEnumType<Type>(Type.class, CONSTRUCTOR);
 
     /**
      * A normal BigQuery table. Instances of {@code TableDefinition} for this type are implemented

diff --git a/samples/src/test/java/com/example/bigquery/ExtractTableToJsonIT.java b/samples/src/test/java/com/example/bigquery/ExtractTableToJsonIT.java
@@ -34,7 +34,7 @@ public class ExtractTableToJsonIT {
 
   private static void requireEnvVar(String varName) {
     assertNotNull(
-        "Environment variable '%s' is required to perform these tests.".format(varName),
+        "Environment variable " + varName + " is required to perform these tests.",
         System.getenv(varName));
   }