Skip to content
This repository has been archived by the owner on Sep 9, 2023. It is now read-only.

fix!: remove unused fields from EnhancedMeasurementSettings #137

Merged
merged 2 commits into from Jan 19, 2021

Conversation

yoshi-automation
Copy link
Contributor

@yoshi-automation yoshi-automation commented Jan 13, 2021

fix!: update_mask field is required for all Update operations
feat: add pagination support for ListFirebaseLinks operation
fix!: rename country_code field to region_code in Account
fix!: rename url_query_parameter field to uri_query_parameter in EnhancedMeasurementSettings
fix!: remove parent field from GoogleAdsLink

This PR was generated using Autosynth. 🌈

Synth log will be available here:
https://source.cloud.google.com/results/invocations/1fd91381-8baf-4747-bdeb-1a9742e427d9/targets

  • To automatically regenerate this PR, check this box.

PiperOrigin-RevId: 351651504
Source-Link: googleapis/googleapis@23e7356

…update_mask` field is required for all Update operations feat: add pagination support for `ListFirebaseLinks` operation fix!: rename `country_code` field to `region_code` in `Account` fix!: rename `url_query_parameter` field to `uri_query_parameter` in `EnhancedMeasurementSettings` fix!: remove `parent` field from `GoogleAdsLink`

PiperOrigin-RevId: 351651504

Source-Author: Google APIs <noreply@google.com>
Source-Date: Wed Jan 13 13:18:19 2021 -0800
Source-Repo: googleapis/googleapis
Source-Sha: 23e7356f4cf449d6e9977698c5d9383b566be7af
Source-Link: googleapis/googleapis@23e7356
@yoshi-automation yoshi-automation requested a review from a team as a code owner January 13, 2021 23:03
@product-auto-label product-auto-label bot added the api: analyticsadmin Issues related to the googleapis/java-analytics-admin API. label Jan 13, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jan 13, 2021
@codecov
Copy link

codecov bot commented Jan 13, 2021

Codecov Report

Merging #137 (8579018) into master (9d0aa7c) will decrease coverage by 0.08%.
The diff coverage is 85.36%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #137      +/-   ##
============================================
- Coverage     84.83%   84.75%   -0.09%     
  Complexity      349      349              
============================================
  Files             6        6              
  Lines          2525     2564      +39     
  Branches         33       34       +1     
============================================
+ Hits           2142     2173      +31     
- Misses          334      341       +7     
- Partials         49       50       +1     
Impacted Files Coverage Δ Complexity Δ
...s/admin/v1alpha/AnalyticsAdminServiceSettings.java 5.38% <ø> (ø) 2.00 <0.00> (ø)
.../admin/v1alpha/stub/AnalyticsAdminServiceStub.java 1.69% <0.00%> (-0.03%) 1.00 <0.00> (ø)
...1alpha/stub/AnalyticsAdminServiceStubSettings.java 83.88% <76.47%> (-0.22%) 58.00 <0.00> (ø)
...ics/admin/v1alpha/AnalyticsAdminServiceClient.java 87.86% <94.73%> (+0.03%) 230.00 <2.00> (ø)
...in/v1alpha/stub/GrpcAnalyticsAdminServiceStub.java 98.12% <100.00%> (-0.09%) 55.00 <1.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d0aa7c...8579018. Read the comment docs.

@chingor13 chingor13 changed the title fix!: remove unused fields from EnhancedMeasurementSettings fix!: update_mask field is required for all Update operations feat: add pagination support for ListFirebaseLinks operation fix!: rename country_code field to region_code in `Accoun fix!: remove unused fields from EnhancedMeasurementSettings Jan 19, 2021
@chingor13 chingor13 self-assigned this Jan 19, 2021
@chingor13 chingor13 added the automerge Merge the pull request once unit tests and other checks pass. label Jan 19, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit db86b2e into master Jan 19, 2021
@gcf-merge-on-green gcf-merge-on-green bot deleted the autosynth-googleapis branch January 19, 2021 18:22
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jan 19, 2021
@release-please release-please bot mentioned this pull request Jan 19, 2021
chingor13 pushed a commit that referenced this pull request Jan 19, 2021
This PR was generated using Autosynth. 🌈

Synth log will be available here:
https://source.cloud.google.com/results/invocations/1fd91381-8baf-4747-bdeb-1a9742e427d9/targets

- [ ] To automatically regenerate this PR, check this box.

PiperOrigin-RevId: 351651504
Source-Link: googleapis/googleapis@23e7356
fix!: `update_mask` field is required for all Update operations
feat: add pagination support for `ListFirebaseLinks` operation
fix!: rename `country_code` field to `region_code` in `Account`
fix!: rename `url_query_parameter` field to `uri_query_parameter` in `EnhancedMeasurementSettings`
fix!: remove `parent` field from `GoogleAdsLink`
gcf-merge-on-green bot pushed a commit that referenced this pull request Jan 19, 2021
🤖 I have created a release \*beep\* \*boop\* 
---
## [0.3.0](https://www.github.com/googleapis/java-analytics-admin/compare/v0.2.5...v0.3.0) (2021-01-19)


### ⚠ BREAKING CHANGES

* `update_mask` field is required for all Update operations
* rename `country_code` field to `region_code` in `Account`
* rename `url_query_parameter` field to `uri_query_parameter` in `EnhancedMeasurementSettings`
* remove `parent` field from `GoogleAdsLink`
* remove unused fields from `EnhancedMeasurementSettings` (#137)

### Features

* add pagination support for `ListFirebaseLinks` operation ([6bfa58c](https://www.github.com/googleapis/java-analytics-admin/commit/6bfa58c307adc8a79dd05345299f8e39ddcf32db))


### Bug Fixes

* `update_mask` field is required for all Update operations ([6bfa58c](https://www.github.com/googleapis/java-analytics-admin/commit/6bfa58c307adc8a79dd05345299f8e39ddcf32db))
* remove `parent` field from `GoogleAdsLink` ([6bfa58c](https://www.github.com/googleapis/java-analytics-admin/commit/6bfa58c307adc8a79dd05345299f8e39ddcf32db))
* remove unused fields from `EnhancedMeasurementSettings` ([#137](https://www.github.com/googleapis/java-analytics-admin/issues/137)) ([6bfa58c](https://www.github.com/googleapis/java-analytics-admin/commit/6bfa58c307adc8a79dd05345299f8e39ddcf32db))
* rename `country_code` field to `region_code` in `Account` ([6bfa58c](https://www.github.com/googleapis/java-analytics-admin/commit/6bfa58c307adc8a79dd05345299f8e39ddcf32db))
* rename `url_query_parameter` field to `uri_query_parameter` in `EnhancedMeasurementSettings` ([6bfa58c](https://www.github.com/googleapis/java-analytics-admin/commit/6bfa58c307adc8a79dd05345299f8e39ddcf32db))


### Documentation

* put markdown table in a codeblock ([#132](https://www.github.com/googleapis/java-analytics-admin/issues/132)) ([15ccf20](https://www.github.com/googleapis/java-analytics-admin/commit/15ccf20bf20791d2a0192d67302e40a46a5cf432))


### Dependencies

* update dependency com.google.cloud:google-cloud-shared-dependencies to v0.18.0 ([#136](https://www.github.com/googleapis/java-analytics-admin/issues/136)) ([6d52546](https://www.github.com/googleapis/java-analytics-admin/commit/6d52546b2fc5703571801d5b8045574ad9985bf1))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: analyticsadmin Issues related to the googleapis/java-analytics-admin API. cla: yes This human has signed the Contributor License Agreement. context: full
Projects
None yet
2 participants