Go: Disable iam admin Get/Set/Test methods #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit disable iam admin's GetIamPolicy, SetIamPolicy, and TestIamPermissions. These methods are to be handwritten later. Update googleapis/google-cloud-go#340
jba
approved these changes
Oct 14, 2016
bjwatson
pushed a commit
that referenced
this pull request
Oct 17, 2016
This commit disable iam admin's GetIamPolicy, SetIamPolicy, and TestIamPermissions. These methods are to be handwritten later. Update googleapis/google-cloud-go#340
pongad
added a commit
that referenced
this pull request
Oct 24, 2016
This is a followup to #173 This commit partially reverts it by setting TestIamPermissions back to public. It also make {Get,Set}IamPolicy private instead of deleting them, to make the hand-written version easier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit disable iam admin's GetIamPolicy, SetIamPolicy,
and TestIamPermissions.
These methods are to be handwritten later.
Update googleapis/google-cloud-go#340
This also affects https://code-review.googlesource.com/#/c/8291/ . I would rather 8291 lands first to reduce churn.