Skip to content

Commit

Permalink
feat: option to ignore_errors while deleting Azure clusters / nodepools
Browse files Browse the repository at this point in the history
PiperOrigin-RevId: 632771413
  • Loading branch information
Google APIs authored and Copybara-Service committed May 11, 2024
1 parent e5eef0f commit 6d798dc
Show file tree
Hide file tree
Showing 3 changed files with 27 additions and 5 deletions.
14 changes: 12 additions & 2 deletions google/cloud/gkemulticloud/v1/BUILD.bazel
Expand Up @@ -9,14 +9,17 @@
# * extra_protoc_file_parameters
# The complete list of preserved parameters can be found in the source code.

# buildifier: disable=load-on-top

# This is an API workspace, having public visibility by default makes perfect sense.
package(default_visibility = ["//visibility:public"])

##############################################################################
# Common
##############################################################################
load("@rules_proto//proto:defs.bzl", "proto_library")
# buildifier: disable=same-origin-load
load("@com_google_googleapis_imports//:imports.bzl", "proto_library_with_info")
load("@rules_proto//proto:defs.bzl", "proto_library")

proto_library(
name = "gkemulticloud_proto",
Expand Down Expand Up @@ -53,6 +56,7 @@ proto_library_with_info(
##############################################################################
# Java
##############################################################################
# buildifier: disable=same-origin-load
load(
"@com_google_googleapis_imports//:imports.bzl",
"java_gapic_assembly_gradle_pkg",
Expand Down Expand Up @@ -119,6 +123,7 @@ java_gapic_assembly_gradle_pkg(
##############################################################################
# Go
##############################################################################
# buildifier: disable=same-origin-load
load(
"@com_google_googleapis_imports//:imports.bzl",
"go_gapic_assembly_pkg",
Expand Down Expand Up @@ -171,6 +176,7 @@ go_gapic_assembly_pkg(
##############################################################################
# Python
##############################################################################
# buildifier: disable=same-origin-load
load(
"@com_google_googleapis_imports//:imports.bzl",
"py_gapic_assembly_pkg",
Expand Down Expand Up @@ -215,6 +221,7 @@ py_gapic_assembly_pkg(
##############################################################################
# PHP
##############################################################################
# buildifier: disable=same-origin-load
load(
"@com_google_googleapis_imports//:imports.bzl",
"php_gapic_assembly_pkg",
Expand Down Expand Up @@ -252,6 +259,7 @@ php_gapic_assembly_pkg(
##############################################################################
# Node.js
##############################################################################
# buildifier: disable=same-origin-load
load(
"@com_google_googleapis_imports//:imports.bzl",
"nodejs_gapic_assembly_pkg",
Expand Down Expand Up @@ -282,6 +290,7 @@ nodejs_gapic_assembly_pkg(
##############################################################################
# Ruby
##############################################################################
# buildifier: disable=same-origin-load
load(
"@com_google_googleapis_imports//:imports.bzl",
"ruby_cloud_gapic_library",
Expand Down Expand Up @@ -335,6 +344,7 @@ ruby_gapic_assembly_pkg(
##############################################################################
# C#
##############################################################################
# buildifier: disable=same-origin-load
load(
"@com_google_googleapis_imports//:imports.bzl",
"csharp_gapic_assembly_pkg",
Expand All @@ -345,7 +355,6 @@ load(

csharp_proto_library(
name = "gkemulticloud_csharp_proto",
extra_opts = [],
deps = [":gkemulticloud_proto"],
)

Expand Down Expand Up @@ -382,6 +391,7 @@ csharp_gapic_assembly_pkg(
##############################################################################
# C++
##############################################################################
# buildifier: disable=same-origin-load
load(
"@com_google_googleapis_imports//:imports.bzl",
"cc_grpc_library",
Expand Down
4 changes: 2 additions & 2 deletions google/cloud/gkemulticloud/v1/aws_resources.proto
Expand Up @@ -564,8 +564,8 @@ message AwsNodeConfig {
// 255 Unicode characters.
map<string, string> tags = 5 [(google.api.field_behavior) = OPTIONAL];

// Required. The name or ARN of the AWS IAM role assigned to nodes in the
// pool.
// Required. The name or ARN of the AWS IAM instance profile to assign to
// nodes in the pool.
string iam_instance_profile = 6 [(google.api.field_behavior) = REQUIRED];

// Optional. The OS image type to use on node pool instances.
Expand Down
14 changes: 13 additions & 1 deletion google/cloud/gkemulticloud/v1/azure_service.proto
Expand Up @@ -472,6 +472,12 @@ message DeleteAzureClusterRequest {
// If the provided etag does not match the current etag of the cluster,
// the request will fail and an ABORTED error will be returned.
string etag = 4;

// Optional. If set to true, the deletion of
// [AzureCluster][google.cloud.gkemulticloud.v1.AzureCluster] resource will
// succeed even if errors occur during deleting in cluster resources. Using
// this parameter may result in orphaned resources in the cluster.
bool ignore_errors = 5 [(google.api.field_behavior) = OPTIONAL];
}

// Response message for `AzureClusters.CreateAzureNodePool` method.
Expand Down Expand Up @@ -635,6 +641,12 @@ message DeleteAzureNodePoolRequest {
// If the provided ETag does not match the current etag of the node pool,
// the request will fail and an ABORTED error will be returned.
string etag = 4;

// Optional. If set to true, the deletion of
// [AzureNodePool][google.cloud.gkemulticloud.v1.AzureNodePool] resource will
// succeed even if errors occur during deleting in node pool resources. Using
// this parameter may result in orphaned resources in the node pool.
bool ignore_errors = 5 [(google.api.field_behavior) = OPTIONAL];
}

// GetAzureOpenIdConfigRequest gets the OIDC discovery document for the
Expand All @@ -658,7 +670,7 @@ message GetAzureOpenIdConfigRequest {
message GetAzureJsonWebKeysRequest {
// Required. The AzureCluster, which owns the JsonWebKeys.
// Format:
// projects/<project-id>/locations/<region>/azureClusters/<cluster-id>
// `projects/<project-id>/locations/<region>/azureClusters/<cluster-id>`
string azure_cluster = 1 [
(google.api.field_behavior) = REQUIRED,
(google.api.resource_reference) = {
Expand Down

0 comments on commit 6d798dc

Please sign in to comment.