Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add 'response_callback' to 'consume' / 'consume_next_chunk' #114

Closed
wants to merge 2 commits into from
Closed

feat: add 'response_callback' to 'consume' / 'consume_next_chunk' #114

wants to merge 2 commits into from

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Nov 13, 2019

Allows callers access to the response objects, e.g., to use HTTP headers.

Closes #113.

@tseaver
feat: add 'response_callback' to 'consume' / 'consume_next_chunk'
e82f4a0 
Allows callers access to the response objects, e.g., to use HTTP headers.

Closes #113.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 13, 2019
@tseaver
Copy link
Contributor Author

tseaver commented Jul 23, 2020

@william-silversmith has submitted a PR to python-storage which makes the general-purpose callback strategy unneeded.

@tseaver tseaver closed this Jul 23, 2020
@tseaver tseaver deleted the 113-add-response_callback-for-downloads branch July 23, 2020 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crwilcox crwilcox Awaiting requested review from crwilcox

@busunkim96 busunkim96 Awaiting requested review from busunkim96

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add 'response_callback' argument to 'consume' / 'consume_next_chunk' methods.
2 participants
@tseaver @googlebot