Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump 'google-crc32c >= 1.0' #162

Merged
merged 1 commit into from Aug 10, 2020
Merged

feat: bump 'google-crc32c >= 1.0' #162

merged 1 commit into from Aug 10, 2020

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Aug 7, 2020

Uses the new namespaced-version of the library.

Release-As: 1.0.0

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 7, 2020
Uses the new namespaced-version of the library.

Release-As: 1.0.0
@crwilcox
Copy link
Collaborator

crwilcox commented Aug 8, 2020

Only concern is releasing as 1.0. We have changes in the pipeline that likely will warrant a major bump

@tseaver tseaver merged commit eaf9faa into googleapis:master Aug 10, 2020
@tseaver tseaver deleted the bump-google-crc32c-to-1.0 branch August 10, 2020 17:40
@william-silversmith
Copy link

The import bug in init.py that was fixed in google-crc32c 1.0.0 was impacting my users here: seung-lab/cloud-volume#385 These problems should be fixed by default once resumable media makes a new release. Until then, I'm pinning google-crc32c to >= 1.0.0 (seung-lab/cloud-files#20)

@tseaver
Copy link
Contributor Author

tseaver commented Aug 27, 2020

@william-silversmith
Copy link

william-silversmith commented Aug 27, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants