Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: oauth1 signing for url encoded content #538

Merged
merged 3 commits into from Feb 2, 2021
Merged

fix: oauth1 signing for url encoded content #538

merged 3 commits into from Feb 2, 2021

Commits on Oct 7, 2020

  1. Fixed OAuth 1.0 signing for requests with URL Encoded Content (typica… 

    …l of POST and PUT HTTP methods)

A simple change the the OAuthParameters intercept method that checks if the request has UrlEncodedContent.  If it does, then its content is added to the GenericUrl so that the signature can be computed correctly.  After the call to computeSignature, the content parameters are removed from the GenericUrl to leave it in its original form.

As per the OAuth 1.0 spec here (https://tools.ietf.org/html/rfc5849#page-28), any form encoded request body with a Content-Type of "application/x-www-form-urlencoded" must be included when the request signature is created.
    @cmunden
    cmunden committed Oct 7, 2020
    Copy the full SHA
    d0ec683 View commit details
    Browse the repository at this point in the history

  2. Changes to support java 1.7. Also added new test code.

    @cmunden
    cmunden committed Oct 7, 2020
    Copy the full SHA
    87662e1 View commit details
    Browse the repository at this point in the history

  3. style: expanded the wild card imports.

    @cmunden
    cmunden committed Oct 7, 2020
    Copy the full SHA
    8d788fd View commit details
    Browse the repository at this point in the history