New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update jetty to 9.4 #432
Update jetty to 9.4 #432
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it!
…On Sun, Feb 16, 2020 at 11:49 AM googlebot ***@***.***> wrote:
Thanks for your pull request. It looks like this may be your first
contribution to a Google open source project (if not, look below for help).
Before we can look at your pull request, you'll need to sign a Contributor
License Agreement (CLA).
📝 *Please visit https://cla.developers.google.com/
<https://cla.developers.google.com/> to sign.*
Once you've signed (or fixed any issues), please reply here with @googlebot
I signed it! and we'll verify it.
------------------------------
What to do if you already signed the CLA Individual signers
- It's possible we don't have your GitHub username or you're using a
different email address on your commit. Check your existing CLA data
<https://cla.developers.google.com/clas> and verify that your email is
set on your git commits
<https://help.github.com/articles/setting-your-email-in-git/>.
Corporate signers
- Your company has a Point of Contact who decides which employees are
authorized to participate. Ask your POC to be added to the group of
authorized contributors. If you don't know who your Point of Contact is,
direct the Google project maintainer to go/cla#troubleshoot (Public
version <https://opensource.google/docs/cla/#troubleshoot>).
- The email used to register you as an authorized contributor must be
the email used for the Git commit. Check your existing CLA data
<https://cla.developers.google.com/clas> and verify that your email is
set on your git commits
<https://help.github.com/articles/setting-your-email-in-git/>.
- The email used to register you as an authorized contributor must
also be attached to your GitHub account
<https://github.com/settings/emails>.
ℹ️ *Googlers: Go here
<https://goto.google.com/prinfo/https%3A%2F%2Fgithub.com%2Fgoogleapis%2Fgoogle-oauth-java-client%2Fpull%2F432>
for more info*.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#432?email_source=notifications&email_token=ABVKI2EXYD7NJD5HJCSHNW3RDFVAFA5CNFSM4KWEZ5R2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEL4MBHY#issuecomment-586727583>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABVKI2BFSSUVV6E7KTDIKQDRDFVAFANCNFSM4KWEZ5RQ>
.
--
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Eric H. Raskin
914-765-0500 x120 or *315-338-4461
(direct)*
Professional Advertising Systems Inc.
fax: 914-765-0500 or *315-338-4461 (direct)*
200 Business Park Drive Suite 304
eraskin@paslists.com
Armonk, NY 10504
http://www.paslists.com
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code appears correct. The reason I'm not approving is that I have concerns where it is being used currently. I don't believe we have any Jetty 8 in use anymore, but I want to check before approval.
…er instead. The original code was dependent on version 8.2 of Jetty. There was a breaking change after 8.2 so that this code would not work with more recent Jetty version (specifically 9.4). Removing the dependency on Jetty removes this incompatibility.
Posting a new pull request replacing Jetty with HttpServer. Maybe this will work better. Should I leave this open or close it? |
fix: Fixes #397 - for compatibility with Jetty 9.4 applications