Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update HttpRequest#getVersion to use stable logic #919

Merged
merged 1 commit into from Dec 17, 2019
Merged

fix: update HttpRequest#getVersion to use stable logic #919

merged 1 commit into from Dec 17, 2019

Commits on Dec 17, 2019

  1. fix: update HttpRequest#getVersion to use stable logic 

    The original implementation of `getVersion` used the implementation
version of the package of the declaring class, however there is
differing behavior between Android and openjdk based jvms.

In order to be consistent across platforms we will now always resolve
the value from the `google-http-client.properties` file that is
generated during the build. This method should be stable as it based
on loading a classpath resource which has cross jvm support.

Fixes #892
    @BenWhitehead
    BenWhitehead committed Dec 17, 2019
    Copy the full SHA
    121e732 View commit details
    Browse the repository at this point in the history