Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GenericUrl to decode path parts correctly #533

Closed
wants to merge 2 commits into from
Closed

Fix GenericUrl to decode path parts correctly #533

wants to merge 2 commits into from

Conversation

ajaaym
Copy link
Contributor

@ajaaym ajaaym commented Dec 4, 2018

Fixes #398 GenericUrl converts plus sign into space within URI path component

  • Tests pass
  • Appropriate docs were updated (if necessary)

@ajaaym ajaaym requested a review from a team as a code owner December 4, 2018 20:34
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 4, 2018
@ajaaym ajaaym changed the title Fix GenericUrl to decode path parts Fix GenericUrl to decode path parts correctly Dec 4, 2018
@chingor13
Copy link
Collaborator

This one is actually non-trivial because it breaks many internal targets (which is why it's been fixed, then reverted several times).

@ajaaym
Copy link
Contributor Author

ajaaym commented Dec 4, 2018

@chingor13 ok thanks. In that case should we put back label status: will not fix in the issue?

@ajaaym ajaaym closed this Dec 10, 2018
yoshi-automation added a commit that referenced this pull request May 11, 2020
@yoshi-automation
ci(java): switch to GitHub Actions (#533)
bd2c70e 
* ci: switch to GitHub Actions

* update based on comment

Source-Author: Stephanie Wang <stephaniewang526@users.noreply.github.com>
Source-Date: Mon May 11 12:54:00 2020 -0400
Source-Repo: googleapis/synthtool
Source-Sha: 55cdc844877d97139f25004229842624a6a86a02
Source-Link: googleapis/synthtool@55cdc84
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ajaaym @chingor13 @googlebot