Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: GH-1375 Improve performance of NetHttpRequest write timeouts by provding a possibility to use custom threadpool #1494

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

dzikoysk
Copy link

@dzikoysk dzikoysk commented Nov 1, 2021

As described in #1375, creating a new thread per execution call pretty much kills the performance of application if it's oriented around high write throughput with configured write timeouts.

The proposed solution allows user to provide custom thread executor, so it's now user's responsibility to handle this kind of scenarios and because it doesn't introduce any kind of strange internal cached threadpool, it's also easier to maintain in the future.

Policy

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1375 ☕️

@dzikoysk dzikoysk requested a review from a team as a code owner November 1, 2021 14:50
@google-cla
Copy link

google-cla bot commented Nov 1, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no This human has *not* signed the Contributor License Agreement. label Nov 1, 2021
@dzikoysk
Copy link
Author

dzikoysk commented Nov 1, 2021

@googlebot I signed it

@google-cla google-cla bot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Nov 1, 2021
@dzikoysk dzikoysk force-pushed the gh-1375/custom-write-timeout-executor branch from f22bb2d to e622b5e Compare November 1, 2021 15:17
@eaball35 eaball35 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 21, 2022
@eaball35 eaball35 changed the title GH-1375 Improve performance of NetHttpRequest write timeouts by provding a possibility to use custom threadpool feat: GH-1375 Improve performance of NetHttpRequest write timeouts by provding a possibility to use custom threadpool Jan 21, 2022
@eaball35 eaball35 added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Apr 6, 2022
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Sep 11, 2022
@dzikoysk
Copy link
Author

Any thoughts on this PR? 🤔 Not sure if I didn't fulfill the requirements of PR, because CI hangs or it's a change you don't want to have in the codebase in general. I'm asking, because it's over a half year and I still need to use self-compiled & distributed artifact with this fix as the current impl is pretty unusable in high throughput environment with configured timeouts.

@meltsufin meltsufin added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. kokoro:force-run Add this label to force Kokoro to re-run the tests. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve performance of NetHttpRequest timeouts by reusing threads
3 participants