Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert the order of stream closure and disconnect #1427

Merged
merged 1 commit into from Sep 23, 2021

Conversation

chanseokoh
Copy link
Contributor

@chanseokoh chanseokoh commented Aug 17, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

Fixes #1409 ☕️

I don't know how exactly #1303 should be resolved, but given the critical nature of #1409, we should revert #1315 now.

@chanseokoh chanseokoh requested a review from a team as a code owner August 17, 2021 20:44
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 17, 2021
@chanseokoh
Copy link
Contributor Author

@chingor13

@lesv
Copy link
Contributor

lesv commented Sep 22, 2021

Ping - @chanseokoh Since it's been almost a month, could you confirm what you want to want (and in what order) you want them to happen here? I see:

  • revert 1315
  • merge this PR

@lesv
Copy link
Contributor

lesv commented Sep 22, 2021

It looks like you are reverting a test from #1315 - so do you still need the whole PR reverted?

@chanseokoh
Copy link
Contributor Author

@lesv you mean #1315, not #1305, right? I am not commit-reverting it, since #1315 has some other refactoring stuff we want to keep. This PR just reverts what's necessary, i.e, the order of stream closure and disconnect. Merging this PR will make everything right.

@chanseokoh chanseokoh merged commit c21e745 into master Sep 23, 2021
@chanseokoh chanseokoh deleted the i1409-disconnect-revert-i1303 branch September 23, 2021 14:21
@chanseokoh chanseokoh changed the title Revert the order of stream closure and disconnect fix: revert the order of stream closure and disconnect Oct 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Premature end of chunk coded message body" and TruncatedChunkException when calling HttpResponse.disconnect()
2 participants