Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix buildRequest setUrl order #1255

Merged
merged 8 commits into from Feb 24, 2021
Merged

fix: fix buildRequest setUrl order #1255

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
61a5ec8
fix: fix buildRequest setUrl order
arithmetic1728 Feb 11, 2021
9a02c92
chore: add unit test
arithmetic1728 Feb 12, 2021
b68464d
update
arithmetic1728 Feb 12, 2021
cebac15
format
arithmetic1728 Feb 12, 2021
1ed1107
Update google-http-client/src/test/java/com/google/api/client/http/Ht…
arithmetic1728 Feb 12, 2021
9880ece
Merge branch 'master' into arithmetic1728-master
chingor13 Feb 23, 2021
3efab8e
Merge branch 'master' into arithmetic1728-master
chingor13 Feb 24, 2021
48db3dd
Update google-http-client/src/test/java/com/google/api/client/http/Ht…
arithmetic1728 Feb 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions google-http-client/src/main/java/com/google/api/client/http/HttpRequestFactory.java
View file
Open in desktop
Expand Up @@ -84,13 +84,13 @@ public HttpRequestInitializer getInitializer() {
public HttpRequest buildRequest(String requestMethod, GenericUrl url, HttpContent content)
throws IOException {
HttpRequest request = transport.buildRequest();
if (url != null) {
request.setUrl(url);
}
if (initializer != null) {
initializer.initialize(request);
}
request.setRequestMethod(requestMethod);
if (url != null) {
request.setUrl(url);
}
if (content != null) {
request.setContent(content);
}
Expand Down