Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: force commons-codec to latest version #1221

Closed
wants to merge 1 commit into from
Closed

deps: force commons-codec to latest version #1221

wants to merge 1 commit into from

Conversation

elharo
Copy link
Contributor

@elharo elharo commented Jan 13, 2021

@elharo elharo requested a review from a team as a code owner January 13, 2021 13:38
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jan 13, 2021
@elharo elharo changed the title force commons-codec to latest version deps: force commons-codec to latest version Jan 13, 2021
chingor13
chingor13 requested changes Jan 13, 2021
View reviewed changes
Copy link
Collaborator

@chingor13 chingor13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to also enable the flatten-maven-plugin or this will only locally use 1.15. The published pom will not include commons-codec and users would get 1.11 transitively via apache httpclient.

@stephaniewang526
Copy link

We are managing this in shared-dependency as discussed: googleapis/java-shared-dependencies#251.

@elharo elharo closed this Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chingor13 chingor13 chingor13 requested changes

@stephaniewang526 stephaniewang526 Awaiting requested review from stephaniewang526

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@elharo @stephaniewang526 @chingor13