feat: decode uri path components correctly #913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old implementation was incorrecly treating '+' as a space. Now the only things that get decoded in the path are uri escaped sequences. Fixes googleapis#398
googlebot
added
the
cla: yes
elharo
reviewed
Dec 10, 2019
google-http-client/src/main/java/com/google/api/client/http/GenericUrl.java
Show resolved
Hide resolved
google-http-client/src/main/java/com/google/api/client/util/escape/CharEscapers.java
Outdated
Show resolved
Hide resolved
google-http-client/src/main/java/com/google/api/client/util/escape/CharEscapers.java
Outdated
Show resolved
Hide resolved
elharo
reviewed
Dec 11, 2019
chingor13
approved these changes
Dec 17, 2019
|
This change caused the problem with using space in object names in java cloud storage: googleapis/java-storage#53 |
|
@dmitry-fa correct, one more issue related to this changes. |
|
Hi, in https://issuetracker.google.com/issues/217399871 we have noticed a problem with Google Sheets API when using It is a bit confusing as the error message we get shows that the problem is that the sheet title is passed in the URL and the plus gets replaced by a space, while the value range in the body remains unchanged and this mismatch results in API failures that prevent adding cells to such sheets. |
clundin25
pushed a commit
to clundin25/google-http-java-client
that referenced
this pull request
Aug 11, 2022
…-plugin to v3.4.0 (googleapis#913) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [org.apache.maven.plugins:maven-javadoc-plugin](https://maven.apache.org/plugins/) ([source](https://togithub.com/apache/maven-javadoc-plugin)) | `3.3.2` -> `3.4.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/google-auth-library-java).
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old implementation was incorrectly treating '+' as a space. Now
the only things that get decoded in the path are uri escaped sequences.
Fixes #398