Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setFollowRedirects(true) does not follow 308 (Permanent Redirect) #873

Closed
chanseokoh opened this issue Nov 1, 2019 · 0 comments · Fixed by #876
Closed

setFollowRedirects(true) does not follow 308 (Permanent Redirect) #873

chanseokoh opened this issue Nov 1, 2019 · 0 comments · Fixed by #876
Assignees
@elharo
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@chanseokoh
Copy link
Contributor

chanseokoh commented Nov 1, 2019 •
edited

Using the latest versions:
google-http-client: 1.33.0
google-http-client-apache-v2: 1.33.0

By default setFollowRedirects(true) is set, and the library automatically follows the following redirects.

301 (Moved Permanently)
302 (Found)
303 (See Other)
307 (Temporary Redirect)

However, 308 (Permanent Redirect) isn't followed from my experiment.

https://en.wikipedia.org/wiki/List_of_HTTP_status_codes#3xx_Redirection says

307 and 308 parallel the behaviors of 302 and 301

so I reckon if the library is following 301, 302, and 307, perhaps it should follow 308 too.
This was referenced Nov 1, 2019
Merged
Merged
@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Nov 2, 2019
@chanseokoh chanseokoh mentioned this issue Nov 4, 2019
Merged
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Nov 6, 2019
@codyoss codyoss added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed 🚨 This issue needs some love. triage me I really want to be triaged. labels Nov 7, 2019
clundin25 pushed a commit to clundin25/google-http-java-client that referenced this issue Aug 11, 2022
@release-please
chore(main): release 1.5.3-SNAPSHOT (googleapis#873)
9a49e82 
🤖 I have created a release *beep* *boop*
---


### Updating meta-information for bleeding-edge SNAPSHOT release.

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elharo elharo

Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: redirect on 308 (Permanent Redirect) too
4 participants
@elharo @codyoss @chanseokoh @yoshi-automation