Upgrade Google HTTP Client to 1.33.0 (Apache v2) #2120
Conversation
|
Is there a concern that we could run into the performance problems from |
|
googleapis/google-http-java-client#855 (comment) fixed the performance issue in my small experiment (code here) where I was pushing 40MB of data to Docker Hub, back to normal. But I'll do some more end-to-end tests before merging. |
|
I find no performance issue with the new google-http-client. |
|
Looks good, I was tracking through the bugs on this performance thing, and I'm confused that the socket buffer is ignored AND that it affected performance? |
jib-core/src/test/java/com/google/cloud/tools/jib/http/WithServerFailoverHttpClientTest.java
Show resolved
Hide resolved
There was a problem hiding this comment.
google-http-client had a longstanding bug where some curated configuration values had been ignored and instead defaults had been used. They fixed it, and applying those values started to cause the performance issue. Then we recently took out some of the curated values (the socket buffer sizes) to use default values, and things got back to normal.
jib-core/src/test/java/com/google/cloud/tools/jib/http/WithServerFailoverHttpClientTest.java
Show resolved
Hide resolved
This is on top of #2118, so review that first.
Fixes #1993. Basically reverting #1980 (which in turn reverted #1882, so this is double-reverting).
And as in Revert Google HTTP Client upgrade #1980, we no longer need to add proxy credentials ourselves, as the Apache v2 automatically takes care of it.
Also removed some unnecessary URL direction code in
RegistryEndpointCaller, as I realized google-http-client by default takes care of them (although it has a bug).Using the Apache v2, this will clear all the deprecated usage warnings around Google HTTP Client.