Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: skip clirr step to allow release #44

Merged
merged 3 commits into from Nov 13, 2020
Merged

fix: skip clirr step to allow release #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d465946
fix: skip clirr step to allow release
grant Nov 13, 2020
7e20a29
fix: ignore clirr in mvn install step
grant Nov 13, 2020
d77a3b0
Merge branch 'master' into grant_clirr
grant Nov 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
13 changes: 10 additions & 3 deletions .github/CONTRIBUTING.md
View file
Open in desktop
Expand Up @@ -17,17 +17,24 @@ Then, to generate, run the ./gen.sh file in the java repo. This will generate th
./tools/gen.sh
```

Observe the new files in `google-cloudevent-types/src/`.
Observe the new files in `src/`.

## Test

Run tests in the `google-cloudevent-types` :
Run tests:

```sh
cd google-cloudevent-types
mvn test
```

## Prepublish Checklist

Install the library to ensure it builds correctly:

```
mvn install -Dclirr.skip
```

## How to Contribute

We'd love to accept your patches and contributions to this project. There are
Expand Down
1 change: 1 addition & 0 deletions .kokoro/release/stage.sh
View file
Open in desktop
Expand Up @@ -29,6 +29,7 @@ create_settings_xml_file "settings.xml"
mvn clean install deploy -B \
--settings ${MAVEN_SETTINGS_FILE} \
-DskipTests=true \
-Dclirr.skip \ # Ignore running clirr for breaking changes. See #43
-DperformRelease=true \
-Dgpg.executable=gpg \
-Dgpg.passphrase=${GPG_PASSPHRASE} \
Expand Down