Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Specify test running prerequisites in CONTRIBUTING.md #244

Merged
merged 3 commits into from Apr 19, 2024

Conversation

grayside
Copy link
Contributor

@grayside grayside commented Apr 4, 2024

This change updates CONTRIBUTING.md to clarify how tests are run. Currently our recommended command is included, but not the prerequisite steps/special instructions to run.

@grayside grayside self-assigned this Apr 4, 2024
@grayside grayside requested a review from a team as a code owner April 4, 2024 16:59
@product-auto-label product-auto-label bot added the api: eventarc Issues related to the googleapis/google-cloudevents-java API. label Apr 4, 2024
CONTRIBUTING.md Outdated Show resolved Hide resolved
@grayside grayside changed the title docs: Clarify test running prerequisites in CONTRIBUTING.md docs: Specify test running prerequisites in CONTRIBUTING.md Apr 4, 2024
Copy link

@iennae iennae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; thanks for updating these so we have the details so folks implementing anything around it can understand how to confirm these work.

@iennae iennae merged commit 739a64a into main Apr 19, 2024
7 checks passed
@iennae iennae deleted the contributing-how-to-test branch April 19, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: eventarc Issues related to the googleapis/google-cloudevents-java API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants