Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Clirr Check #43

Open
grant opened this issue Nov 13, 2020 · 0 comments
Open

Add Clirr Check #43

grant opened this issue Nov 13, 2020 · 0 comments
Labels
api: eventarc Issues related to the googleapis/google-cloudevents-java API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@grant
Copy link
Contributor

grant commented Nov 13, 2020

Expected Behavior

This library should list breaking changes such that mvn clirr:check passes.

This can be achieved by creating a new file:

clirr-ignored-differences.xml

And making sure that we do not skip the clirr check by removing this line (no skip in .kokoro/stage.sh):

-Dclirr.skip

Examples:

Actual Behavior

This check is disabled.
@product-auto-label product-auto-label bot added the api: eventarc Issues related to the googleapis/google-cloudevents-java API. label Nov 13, 2020
@grant grant mentioned this issue Nov 13, 2020
Merged
gcf-merge-on-green bot pushed a commit that referenced this issue Nov 13, 2020
@grant
fix: skip clirr step to allow release (#44)
2c69e44 
Skip clirr check as there are known breaking changes to this artifact (when we changed generators).

- Fixes: #40
- Related: #43
@yoshi-automation yoshi-automation added 🚨 This issue needs some love. triage me I really want to be triaged. labels Jan 29, 2021
@grant grant added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p3 Desirable enhancement or fix. May not be included in next release. and removed triage me I really want to be triaged. labels Feb 3, 2021
@yoshi-automation yoshi-automation removed the 🚨 This issue needs some love. label Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api: eventarc Issues related to the googleapis/google-cloudevents-java API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@grant @yoshi-automation