Skip to content

Commit

Permalink
fix: skip clirr step to allow release (#44)
Browse files Browse the repository at this point in the history
Skip clirr check as there are known breaking changes to this artifact (when we changed generators).

- Fixes: #40
- Related: #43
  • Loading branch information
grant committed Nov 13, 2020
1 parent 7b7aaa7 commit 2c69e44
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 3 deletions.
13 changes: 10 additions & 3 deletions .github/CONTRIBUTING.md
Expand Up @@ -17,17 +17,24 @@ Then, to generate, run the ./gen.sh file in the java repo. This will generate th
./tools/gen.sh
```

Observe the new files in `google-cloudevent-types/src/`.
Observe the new files in `src/`.

## Test

Run tests in the `google-cloudevent-types` :
Run tests:

```sh
cd google-cloudevent-types
mvn test
```

## Prepublish Checklist

Install the library to ensure it builds correctly:

```
mvn install -Dclirr.skip
```

## How to Contribute

We'd love to accept your patches and contributions to this project. There are
Expand Down
1 change: 1 addition & 0 deletions .kokoro/release/stage.sh
Expand Up @@ -29,6 +29,7 @@ create_settings_xml_file "settings.xml"
mvn clean install deploy -B \
--settings ${MAVEN_SETTINGS_FILE} \
-DskipTests=true \
-Dclirr.skip \ # Ignore running clirr for breaking changes. See #43
-DperformRelease=true \
-Dgpg.executable=gpg \
-Dgpg.passphrase=${GPG_PASSPHRASE} \
Expand Down

0 comments on commit 2c69e44

Please sign in to comment.