Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pubsub): Set client-scoped UUID in initial StreamingPullRequest#client_id #5925

Merged
merged 1 commit into from May 8, 2020
Merged

feat(pubsub): Set client-scoped UUID in initial StreamingPullRequest#client_id #5925

merged 1 commit into from May 8, 2020
+37 −0

Conversation

quartzmo
Copy link
Member

@quartzmo quartzmo commented May 6, 2020

closes: #5924

@quartzmo quartzmo requested a review from a team as a code owner May 6, 2020 22:07
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 6, 2020
@quartzmo quartzmo requested a review from hongalex May 6, 2020 22:08
@quartzmo quartzmo added the api: pubsub Issues related to the Pub/Sub API. label May 6, 2020
@quartzmo quartzmo self-assigned this May 7, 2020
dazuma
dazuma approved these changes May 7, 2020
View reviewed changes
Copy link
Member

@dazuma dazuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but with a question.

google-cloud-pubsub/lib/google/cloud/pubsub/service.rb Show resolved Hide resolved
@quartzmo
Copy link
Member Author

quartzmo commented May 8, 2020

@hongalex PTAL

@quartzmo quartzmo merged commit 68aa01a into googleapis:master May 8, 2020
@quartzmo quartzmo deleted the pubsub-pull-request-client-id branch May 8, 2020 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dazuma dazuma dazuma approved these changes

@hongalex hongalex hongalex approved these changes

Assignees

@quartzmo quartzmo

Labels
api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set StreamingPullRequest#client_id with UUID scoped to client instance
4 participants
@quartzmo @dazuma @hongalex @googlebot