feat: Add a test proxy for Bigtable client conformance tests #25680
+943
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
meagar
commented
Apr 15, 2024
meagar
force-pushed
the
bigtable-conformance-tests
branch
from
6a08613
to
49113c6
Compare
meagar
commented
Apr 15, 2024
meagar
force-pushed
the
bigtable-conformance-tests
branch
2 times, most recently
from
cc23ad4
to
351fb41
Compare
meagar
changed the title
meagar
commented
Apr 15, 2024
meagar
changed the title
meagar
changed the title
meagar
force-pushed
the
bigtable-conformance-tests
branch
from
351fb41
to
12448db
Compare
This was referenced Apr 16, 2024
mutianf
reviewed
Apr 17, 2024
dazuma
reviewed
Apr 24, 2024
mutianf
approved these changes
Apr 26, 2024
meagar
force-pushed
the
bigtable-conformance-tests
branch
from
bd793dc
to
c075534
Compare
dazuma
approved these changes
Apr 29, 2024
|
The conventional commit message should't be |
|
fix(bigtable): Fixes for using a preconfigured GRPC channel as credentials |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a test proxy required for Bigtable client conformance tests, per https://github.com/googleapis/cloud-bigtable-clients-test, as well as some small (I believe non-breaking) changes in
google-cloud-bigtableto allow the test proxy to work.The test harness is written in Go, and provides its own (very simple) mock implementation of Bigtable. The test proxy exposes a number of RPC calls that are thin wrappers around the language-specific client library, so the test harness can tell the proxy to make various permutations of typical Bigtable calls (read row, check-and-mutate, etc) and verify the client's behavior by looking at how it interacts with the mock Bigtable implementation, and the types of responses the proxy returns.
This PR also includes a couple minor fixes to
google-cloud-bigtablewhich I think generally update the code to reflect the existing documentation comments (so they require no documentation change).It's worth mentioning that I tried to fail early with clear error messages in any place in the proxy that the current test suite didn't cause to be executed, and I didn't feel comfortable authoring an implementation that I'd have no way of testing. This should provide good feedback for future maintainers to understand where to make changes, should new tests trip my asserts/aborts.
closes: #25682