New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(spanner): add spangres support #17661
Conversation
NivedhaSenthil
commented
Feb 17, 2022
- add support for new type pg_numeric
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest enabling rubocop on the acceptance test files, as there are a lot of style and readability issues. I marked a few representative instances, but there are a lot more.
google-cloud-spanner/acceptance/spanner/client/batch_update_test.rb
Outdated
Show resolved
Hide resolved
google-cloud-spanner/acceptance/spanner/client/params/pgnumeric_test.rb
Outdated
Show resolved
Hide resolved
google-cloud-spanner/acceptance/spanner/client/params/pgnumeric_test.rb
Outdated
Show resolved
Hide resolved
google-cloud-spanner/acceptance/spanner/client/types/pgnumeric_test.rb
Outdated
Show resolved
Hide resolved
google-cloud-spanner/acceptance/spanner/client/params/pgnumeric_test.rb
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the work on this. Looking much better!