Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storage): Changing the test email id. #16095

Merged
merged 1 commit into from Nov 30, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion google-cloud-storage/acceptance/storage/bucket_acl_test.rb
Expand Up @@ -20,7 +20,7 @@
storage.bucket(bucket_name) ||
safe_gcs_execute { storage.create_bucket(bucket_name) }
end
let(:user_val) { "user-blowmage@gmail.com" }
let(:user_val) { "user-test@example.com" }

before do
# always reset the bucket permissions
Expand Down
Expand Up @@ -20,15 +20,15 @@
storage.bucket(bucket_name) ||
safe_gcs_execute { storage.create_bucket(bucket_name) }
end
let(:user_val) { "user-blowmage@gmail.com" }
let(:user_val) { "user-test@example.com" }

before do
# always reset the bucket permissions
bucket.default_acl.private!
end

it "adds a reader" do
user_val = "user-blowmage@gmail.com"
user_val = "user-test@example.com"
_(bucket.default_acl.readers).wont_include user_val
bucket.default_acl.add_reader user_val
_(bucket.default_acl.readers).must_include user_val
Expand All @@ -39,7 +39,7 @@
end

it "adds an owner" do
user_val = "user-blowmage@gmail.com"
user_val = "user-test@example.com"
_(bucket.default_acl.owners).wont_include user_val
bucket.default_acl.add_owner user_val
_(bucket.default_acl.owners).must_include user_val
Expand Down
Expand Up @@ -36,8 +36,8 @@
end
# The bucket used in tests is retrieved by the main project, with user_project set to bill to the main project.
let(:bucket) { storage.bucket bucket_name, user_project: true }
let(:user_val) { "user-blowmage@gmail.com" }
let(:group_val) { "user-blowmage@gmail.com" }
let(:user_val) { "user-test@example.com" }
let(:group_val) { "user-test@example.com" }

let(:file_path) { "acceptance/data/CloudPlatform_128px_Retina.png" }

Expand Down
Expand Up @@ -27,7 +27,7 @@
end
let(:local_file) { File.new files[:logo][:path] }

let(:user_val) { "user-blowmage@gmail.com" }
let(:user_val) { "user-test@example.com" }

after do
# always reset the uniform_bucket_level_access and public_access_prevention
Expand Down
6 changes: 3 additions & 3 deletions google-cloud-storage/acceptance/storage/file_acl_test.rb
Expand Up @@ -27,7 +27,7 @@
end
let(:local_file) { File.new files[:logo][:path] }

let(:user_val) { "user-blowmage@gmail.com" }
let(:user_val) { "user-test@example.com" }

before do
# always create the bucket and set default acl to auth
Expand All @@ -40,7 +40,7 @@

it "adds a reader" do
file = bucket.create_file local_file, "ReaderTest.png"
user_val = "user-blowmage@gmail.com"
user_val = "user-test@example.com"
_(file.acl.readers).wont_include user_val
file.acl.add_reader user_val
_(file.acl.readers).must_include user_val
Expand All @@ -52,7 +52,7 @@

it "adds an owner" do
file = bucket.create_file local_file, "OwnerTest.png"
user_val = "user-blowmage@gmail.com"
user_val = "user-test@example.com"
_(file.acl.owners).wont_include user_val
file.acl.add_owner user_val
_(file.acl.owners).must_include user_val
Expand Down
2 changes: 1 addition & 1 deletion google-cloud-storage/samples/acceptance/acls_test.rb
Expand Up @@ -18,7 +18,7 @@
describe "ACL Snippets" do
let(:storage_client) { Google::Cloud::Storage.new }
let(:local_file) { File.expand_path "data/file.txt", __dir__ }
let(:email) { "user-test@test.com" }
let(:email) { "user-test@example.com" }
let(:remote_file_name) { "path/file_name.txt" }
let(:bucket) { @bucket }

Expand Down