Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spanner: allow user-agent to be passed in and not a hardcoded version #4761

Closed
odeke-em opened this issue Feb 2, 2020 · 3 comments
Closed
Assignees
Labels
api: spanner Issues related to the Spanner API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@odeke-em
Copy link

odeke-em commented Feb 2, 2020

We'd like to be able to pass in a user-agent from applications that build atop spanner-ruby (we are currently building an ORM plugin),
where ideally the final user-agent when set by us would be

x-goog-api-client': \
'spanner-activerecord/0.0.1 gl-ruby/<VERSION> grpc/<gRPC_VERSION> gax/<GAX_VERSION>' 

Coming here from a report by @jiren on January 19th 2020, which I shall quote verbatim:

@odeke-em In ruby spanner this is not possible as per current implementation. Ruby spanner lib has hardcoded values.

lib_name: "gccl",
lib_version: Google::Cloud::Spanner::VERSION

Here is the file link,

lib_name: "gccl",
lib_version: Google::Cloud::Spanner::VERSION

I think need to create an issue on spanner ruby.

This issue is to follow up with @jiren's report. /cc @skuruppu

@quartzmo quartzmo added api: spanner Issues related to the Spanner API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Feb 2, 2020
@quartzmo
Copy link
Member

quartzmo commented Feb 2, 2020

@odeke-em Thanks for this request. @jiren Do you want to take this?

@jiren
Copy link
Member

jiren commented Feb 3, 2020

@odeke-em Thanks for this request. @jiren Do you want to take this?

Yes @quartzmo , I have created pull request against this.

@jiren jiren self-assigned this Feb 3, 2020
@skuruppu
Copy link
Contributor

Thanks to @quartzmo, #4762 is now in google-cloud-spanner 1.14.0. Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the Spanner API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

4 participants