Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connection: ensure that we pass in a user-agent to our connections for usage tracking #4

Closed
odeke-em opened this issue Jan 20, 2020 · 5 comments
Assignees

Comments

@odeke-em
Copy link
Contributor

We MUST pass in a user-agent into our connection for the purpose of usage tracking for example as per

x-goog-api-client': \
'spanner-activerecord/0.0.1 gl-ruby/<VERSION> grpc/<gRPC_VERSION> gax/<GAX_VERSION>' 
@jiren
Copy link
Member

jiren commented Jan 20, 2020

@odeke-em In ruby spanner this is not possible as per current implementation. Ruby spanner lib has hardcoded values.

lib_name: "gccl",
lib_version: Google::Cloud::Spanner::VERSION

Here is the file link,
https://github.com/googleapis/google-cloud-ruby/blob/fe8f239bd97c2bdadb4da5a3012cc4cd738a7efa/google-cloud-spanner/lib/google/cloud/spanner/service.rb#L54-L55

I think need to create an issue on spanner ruby.

@odeke-em
Copy link
Contributor Author

odeke-em commented Feb 2, 2020

Hey @jiren, how's it going here?

@odeke-em
Copy link
Contributor Author

odeke-em commented Feb 2, 2020

I've filed googleapis/google-cloud-ruby#4761.

@odeke-em
Copy link
Contributor Author

Shall we close this issue @jiren? Could you please confirm that this is fixed?

@jiren jiren closed this as completed Mar 14, 2020
@jiren
Copy link
Member

jiren commented Mar 14, 2020

Yes it is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants