Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(spanner): add spangres support #17661

Merged
merged 20 commits into from Mar 31, 2022
Merged

feat(spanner): add spangres support #17661

merged 20 commits into from Mar 31, 2022

Conversation

NivedhaSenthil
Copy link
Member

  • add support for new type pg_numeric

@NivedhaSenthil NivedhaSenthil requested review from a team as code owners February 17, 2022 05:03
@product-auto-label product-auto-label bot added the api: spanner Issues related to the Spanner API. label Feb 17, 2022
@NivedhaSenthil NivedhaSenthil added do not merge Indicates a pull request not ready for merge, due to either quality or timing. api: spanner Issues related to the Spanner API. and removed api: spanner Issues related to the Spanner API. labels Feb 17, 2022
dazuma
dazuma requested changes Feb 18, 2022
View reviewed changes
Copy link
Member

@dazuma dazuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest enabling rubocop on the acceptance test files, as there are a lot of style and readability issues. I marked a few representative instances, but there are a lot more.

acceptance/data/fixtures.rb Show resolved Hide resolved
acceptance/data/fixtures.rb Outdated Show resolved Hide resolved
acceptance/data/fixtures.rb Outdated Show resolved Hide resolved
acceptance/data/fixtures.rb Outdated Show resolved Hide resolved
google-cloud-spanner/acceptance/spanner/client/batch_update_test.rb Outdated Show resolved Hide resolved
google-cloud-spanner/acceptance/spanner/client/params/pgnumeric_test.rb Outdated Show resolved Hide resolved
google-cloud-spanner/acceptance/spanner/client/params/pgnumeric_test.rb Outdated Show resolved Hide resolved
google-cloud-spanner/acceptance/spanner/client/types/pgnumeric_test.rb Outdated Show resolved Hide resolved
google-cloud-spanner/acceptance/spanner/client/params/pgnumeric_test.rb Outdated Show resolved Hide resolved
google-cloud-spanner/lib/google/cloud/spanner/convert.rb Outdated Show resolved Hide resolved
@NivedhaSenthil NivedhaSenthil added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 23, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 23, 2022
dazuma
dazuma approved these changes Mar 30, 2022
View reviewed changes
Copy link
Member

@dazuma dazuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work on this. Looking much better!

@NivedhaSenthil NivedhaSenthil removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 31, 2022
@NivedhaSenthil NivedhaSenthil merged commit 60da558 into googleapis:main Mar 31, 2022
@NivedhaSenthil NivedhaSenthil deleted the pg-support branch March 31, 2022 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dazuma dazuma dazuma approved these changes

Assignees
No one assigned
Labels
api: spanner Issues related to the Spanner API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@NivedhaSenthil @dazuma @yoshi-kokoro