Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pubsub): handle None in on response callback #9982

Merged
merged 1 commit into from Dec 16, 2019
Merged

fix(pubsub): handle None in on response callback #9982

merged 1 commit into from Dec 16, 2019

Commits on Dec 16, 2019

  1. fix(pubsub): handle None in on response callback 

    If the underlying RPC is shut down while pulling the messages with a
streming pull, the StreamingPullManager's _on_response() method is
invoked with None (as opposed to a StreamingPullResponse instance).

This commit handles this case and prevents an error in a background
thread on streaming pull manager shutdown.
    @plamut
    plamut committed Dec 16, 2019
    Copy the full SHA
    8b9e652 View commit details
    Browse the repository at this point in the history