Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(datastore): add return query object in add filter method #9892

Closed
wants to merge 1 commit into from
Closed

feat(datastore): add return query object in add filter method #9892

wants to merge 1 commit into from

Conversation

HemangChothani
Copy link
Contributor

Fixes #9876

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 26, 2019
BenWhitehead
BenWhitehead reviewed Jan 9, 2020
View reviewed changes
Copy link
Contributor

@BenWhitehead BenWhitehead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conceptually this seems okay to me, but I'll defer to my more python knowledgeable colleagues to determine if this is a safe API change.

@HemangChothani
Copy link
Contributor Author

Closing this PR as suppressed by 12 in new repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenWhitehead BenWhitehead BenWhitehead left review comments

@crwilcox crwilcox Awaiting requested review from crwilcox

@frankyn frankyn Awaiting requested review from frankyn

@tseaver tseaver Awaiting requested review from tseaver

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@HemangChothani @BenWhitehead @googlebot