Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(pubsub): bump copyright year to 2020 (via synth) #10236

Closed
wants to merge 1 commit into from
Closed

chore(pubsub): bump copyright year to 2020 (via synth) #10236

wants to merge 1 commit into from

Conversation

yoshi-automation
Copy link
Contributor

This PR was generated using Autosynth. 🌈

Commits in this repo since last synth:
01b7fb9 docs(bigquery): typo fix (#10209)
9ad21f4 feat(core): change default api_request() timeout to non-None (#10219)
8a0e129 fix(automl): fix TablesClient.predict for array and struct (#9991)
7e36fda deprecate(bigquery): deprecate client.dataset() in favor of DatasetReference (#7753)
73eac04 chore(recommender): release 0.2.0 (#10204)
c411e14 feat(recommender): add v1, set release level to beta (#10170)
8e7b7f8 feat(api_core): add retry param into PollingFuture() and it's inheritors (#9923)
0280a94 feat(bigquery): check rows argument type in insert_rows() (#10174)
3c4335d feat(bigquerydatatransfer): add service_account_name option to transfer configs (#10013)
a51da49 test(datacatalog): run unit tests with Python 3.8 (#10014)
c61c238 fix: be permssive about merging an empty struct (#10079)

Log from Synthtool 
synthtool > Executing /tmpfs/src/git/autosynth/working_repo/pubsub/synth.py.
synthtool > Ensuring dependencies.
synthtool > Pulling artman image.
latest: Pulling from googleapis/artman
Digest: sha256:19e945954fc960a4bdfee6cb34695898ab21a8cf0bac063ee39b91f00a1faec8
Status: Image is up to date for googleapis/artman:latest
synthtool > Cloning googleapis.
synthtool > Running generator for google/pubsub/artman_pubsub.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/pubsub-v1.
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/pubsub/v1/pubsub.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/pubsub-v1/google/cloud/pubsub_v1/proto/pubsub.proto
synthtool > Placed proto files into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/pubsub-v1/google/cloud/pubsub_v1/proto.
synthtool > Replaced 'from google.cloud import pubsub_v1' in tests/unit/gapic/v1/test_publisher_client_v1.py.
synthtool > Replaced ' pubsub_v1' in tests/unit/gapic/v1/test_publisher_client_v1.py.
synthtool > Replaced 'from google.cloud import pubsub_v1' in tests/unit/gapic/v1/test_subscriber_client_v1.py.
synthtool > Replaced ' pubsub_v1' in tests/unit/gapic/v1/test_subscriber_client_v1.py.
synthtool > Replaced '# The name of the interface for this client. This is the key used to' in google/cloud/pubsub_v1/gapic/subscriber_client.py.
synthtool > Replaced '# The name of the interface for this client. This is the key used to' in google/cloud/pubsub_v1/gapic/publisher_client.py.
synthtool > Replaced 'import google.api_core.gapic_v1.method\n' in google/cloud/pubsub_v1/gapic/publisher_client.py.
synthtool > Replaced 'DESCRIPTOR = _MESSAGESTORAGEPOLICY,\n\\s+__module__.*\n\\s+,\n\\s+__doc__ = """' in google/cloud/pubsub_v1/proto/pubsub_pb2.py.
synthtool > No replacements made in google/cloud/pubsub_v1/gapic/subscriber_client.py for pattern subscription \(str\): The subscription whose backlog .*
(.*
)+?\s+Format is .*, maybe replacement is not longer needed?
synthtool > Replaced 'import functools\n' in google/cloud/pubsub_v1/gapic/publisher_client.py.
synthtool > Replaced 'import pkg_resources\n' in google/cloud/pubsub_v1/gapic/publisher_client.py.
synthtool > Replaced 'class PublisherClient' in google/cloud/pubsub_v1/gapic/publisher_client.py.
synthtool > Replaced 'client_config \\(dict\\): DEPRECATED.' in google/cloud/pubsub_v1/gapic/publisher_client.py.
synthtool > Replaced '# Raise deprecation warnings .*\n.*\n.*\n.*\n.*\n.*\n' in google/cloud/pubsub_v1/gapic/publisher_client.py.
synthtool > Replaced '~google.api_core.page_iterator.PageIterator' in google/cloud/pubsub_v1/gapic/publisher_client.py.
synthtool > Replaced '~google.api_core.page_iterator.PageIterator' in google/cloud/pubsub_v1/gapic/subscriber_client.py.
synthtool > Replaced 'from google.iam.v1 import iam_policy_pb2' in google/cloud/pubsub_v1/gapic/transports/subscriber_grpc_transport.py.
synthtool > Replaced 'from google.iam.v1 import iam_policy_pb2' in google/cloud/pubsub_v1/gapic/transports/publisher_grpc_transport.py.
.coveragerc
.flake8
MANIFEST.in
docs/_static/custom.css
docs/_templates/layout.html
noxfile.py.j2
setup.cfg
Running session blacken
Creating virtual environment (virtualenv) using python3.6 in .nox/blacken
pip install black==19.3b0
black docs google tests noxfile.py setup.py
reformatted /tmpfs/src/git/autosynth/working_repo/pubsub/google/__init__.py
reformatted /tmpfs/src/git/autosynth/working_repo/pubsub/google/cloud/__init__.py
reformatted /tmpfs/src/git/autosynth/working_repo/pubsub/google/cloud/pubsub.py
reformatted /tmpfs/src/git/autosynth/working_repo/pubsub/google/cloud/pubsub_v1/gapic/publisher_client_config.py
reformatted /tmpfs/src/git/autosynth/working_repo/pubsub/google/cloud/pubsub_v1/gapic/subscriber_client_config.py
reformatted /tmpfs/src/git/autosynth/working_repo/pubsub/google/cloud/pubsub_v1/gapic/transports/publisher_grpc_transport.py
reformatted /tmpfs/src/git/autosynth/working_repo/pubsub/google/cloud/pubsub_v1/gapic/transports/subscriber_grpc_transport.py
reformatted /tmpfs/src/git/autosynth/working_repo/pubsub/google/cloud/pubsub_v1/gapic/publisher_client.py
reformatted /tmpfs/src/git/autosynth/working_repo/pubsub/google/cloud/pubsub_v1/proto/pubsub_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/pubsub/google/cloud/pubsub_v1/gapic/subscriber_client.py
reformatted /tmpfs/src/git/autosynth/working_repo/pubsub/tests/system/gapic/v1/test_system_publisher_v1.py
reformatted /tmpfs/src/git/autosynth/working_repo/pubsub/noxfile.py
reformatted /tmpfs/src/git/autosynth/working_repo/pubsub/tests/unit/gapic/v1/test_publisher_client_v1.py
reformatted /tmpfs/src/git/autosynth/working_repo/pubsub/tests/unit/gapic/v1/test_subscriber_client_v1.py
reformatted /tmpfs/src/git/autosynth/working_repo/pubsub/google/cloud/pubsub_v1/proto/pubsub_pb2.py
All done! ✨ 🍰 ✨
15 files reformatted, 49 files left unchanged.
Session blacken was successful.
synthtool > Wrote metadata to synth.metadata.

@yoshi-automation yoshi-automation added the api: pubsub Issues related to the Pub/Sub API. label Jan 29, 2020
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 29, 2020
busunkim96
busunkim96 reviewed Jan 30, 2020
View reviewed changes
pubsub/google/cloud/pubsub_v1/gapic/publisher_client.py
@@ -51,10 +51,10 @@


# TODO: remove conditional import after Python 2 support is dropped
if six.PY3:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't notice this when this change was being reviewed, but we'd have to make this change to the templates in gapic-generator to make this permanent. I don't anticipate us staying on the monolith(or supporting Python 2) past the first half of this year.

@plamut Would you be alright with letting this change be reverted? A synth replace is also an option if you feel it is important for Pub/Sub in particular.

Mostly trying to clear out synth PRs before repo split on Friday :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@busunkim96 You mean reverting the change back to checking "if PY3"?

While this fix by an external contributor was welcome, it won't be applicable in the foreseeable future, as Python 4 has not been announced yet, and it's nearly certain that Python 2 support will be dropped way before that.

Feel free to do anything that makes the job on your part easier. :)

@busunkim96 busunkim96 changed the title [CHANGE ME] Re-generated pubsub to pick up changes in the API or client library generator. chore(pubsub): bump copyright year to 2020 (via synth) Jan 30, 2020
plamut
plamut reviewed Jan 30, 2020
View reviewed changes
Copy link
Contributor

@plamut plamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I just have a question about a backslash.

The synth.metadata diff seems larger than usual (I might be wrong), but I assume that's correct. :)

pubsub/google/cloud/pubsub_v1/proto/pubsub_pb2.py
token <https://developers.google.com/identity/protocols/OpenIDConnect>`__.


Attributes:
service_account_email:
`Service account email
\ `Service account email
Copy link
Contributor

@plamut plamut Jan 30, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the role of this backslash here? 😕
(could it be some kind of a leftover or a generator bug?)

@plamut plamut added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 31, 2020
@plamut
Copy link
Contributor

plamut commented Jan 31, 2020

Starting the repo split, please do not merge.

@busunkim96
Copy link
Contributor

Closing, googleapis/python-pubsub#25 is the equivalent in the new repo.

@busunkim96 busunkim96 closed this Feb 4, 2020
@tseaver tseaver deleted the autosynth-pubsub branch August 24, 2021 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plamut plamut plamut left review comments

@busunkim96 busunkim96 busunkim96 left review comments

@pradn pradn pradn approved these changes

@anguillanneuf anguillanneuf Awaiting requested review from anguillanneuf

Assignees
No one assigned
Labels
api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement. do not merge Indicates a pull request not ready for merge, due to either quality or timing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@yoshi-automation @plamut @busunkim96 @pradn @googlebot