Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: call get ApiFuture object to prevent RejectedExecutionException #6787

Closed
wants to merge 1 commit into from

Conversation

mannuscript
Copy link

Fixes #6784

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 14, 2019
@pmakani pmakani added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 15, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 15, 2019
@codecov
Copy link

codecov bot commented Nov 15, 2019

Codecov Report

Merging #6787 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6787      +/-   ##
============================================
- Coverage     46.37%   46.37%   -0.01%     
- Complexity    28026    28028       +2     
============================================
  Files          2614     2615       +1     
  Lines        288327   288309      -18     
  Branches      33810    33809       -1     
============================================
- Hits         133723   133710      -13     
+ Misses       144339   144334       -5     
  Partials      10265    10265
Impacted Files Coverage Δ Complexity Δ
...oogle/cloud/spanner/jdbc/SingleUseTransaction.java 86% <0%> (-1%) 36% <0%> (-1%)
.../google/cloud/spanner/jdbc/CredentialsService.java 90.47% <0%> (-0.64%) 8% <0%> (-3%)
...rc/main/java/com/google/cloud/storage/Storage.java 79.39% <0%> (ø) 0% <0%> (ø) ⬇️
...google/cloud/logging/logback/MDCEventEnhancer.java 83.33% <0%> (ø) 4% <0%> (?)
.../google/cloud/logging/logback/LoggingAppender.java 68.5% <0%> (+4.72%) 30% <0%> (+2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 740c755...b7e1437. Read the comment docs.

@hannahrogers-google hannahrogers-google added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 19, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 19, 2019
@hannahrogers-google
Copy link

Hi @mannuscript, thanks for bringing this to our attention! And thanks for creating this PR. I agree that this example should definitely be updated. However, we would like to change this example so that it matches other Publish examples that we give in the library.

I am going to close this PR for now, and will update the README examples soon. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
5 participants