Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(spanner): remove the need for github.com/stretchr/testify #9760

Merged
merged 4 commits into from May 2, 2024
Merged

chore(spanner): remove the need for github.com/stretchr/testify #9760

merged 4 commits into from May 2, 2024
+110 −147

Conversation

egonelbre
Copy link
Contributor

Updates #9378

@egonelbre egonelbre requested review from a team as code owners April 12, 2024 10:59
@product-auto-label product-auto-label bot added the api: spanner Issues related to the Spanner API. label Apr 12, 2024
@rahul2393
Copy link
Contributor

@egonelbre Can you please fix the conflicts here?

@egonelbre
Copy link
Contributor Author

@rahul2393 done, although it was just a go mod tidy compared to main.

@rahul2393 rahul2393 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 2, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 2, 2024
@rahul2393 rahul2393 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 2, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 2, 2024
@rahul2393 rahul2393 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 2, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 2, 2024
@rahul2393 rahul2393 enabled auto-merge (squash) May 2, 2024 06:53
@rahul2393 rahul2393 merged commit 5a8c889 into googleapis:main May 2, 2024
11 checks passed
@egonelbre egonelbre deleted the notestify branch May 2, 2024 06:59
@noahdietz noahdietz mentioned this pull request May 2, 2024
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request May 2, 2024
@noahdietz
chore(thirdpartycheck): remove testify exemption (#10087)
3bbe6d5 
Since `testify` was removed from spanner in #9760 we can remove the exemption for it, so that it won't be added back.

Fixes #9378
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahul2393 rahul2393 rahul2393 approved these changes

Assignees
No one assigned
Labels
api: spanner Issues related to the Spanner API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@egonelbre @rahul2393 @kokoro-team