Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pubsub): support publisher compression #9711

Merged
merged 4 commits into from Apr 29, 2024

Conversation

hongalex
Copy link
Member

@hongalex hongalex commented Apr 4, 2024

Similar to Java, this PR adds gRPC compression support to the Publish method specifically.

This does not add change the number of bytes that Pub/Sub charges for, as it is compressed and decompressed in transit. Currently, only gzip is supported.

internal issue: 226594738

@hongalex hongalex requested review from shollyman and a team as code owners April 4, 2024 21:23
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the Pub/Sub API. label Apr 4, 2024
Copy link
Contributor

@alvarowolfx alvarowolfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks good to me feature wise, but I added a comment on how to improve the call to .Publish to avoid having two code paths calling it.

pubsub/topic.go Show resolved Hide resolved
pubsub/topic.go Show resolved Hide resolved
@hongalex hongalex enabled auto-merge (squash) April 29, 2024 16:35
@hongalex hongalex merged commit 4940c3c into googleapis:main Apr 29, 2024
8 checks passed
ma-g-22 pushed a commit to ma-g-22/google-cloud-go that referenced this pull request Apr 29, 2024
* feat(pubsub): support publisher compression

* address review comments
@hongalex hongalex deleted the pubsub-publisher-compression branch April 29, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the Pub/Sub API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants