feat(bigtable): Support AuthorizedView in data and admin client #9515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: l
bhshkh
reviewed
Mar 6, 2024
|
Please revert go.mod go.work.sum and go.sum as they will affect rest of the packages. To update these files, there will be an auto-generated PR by renovate-bot . Similar to https://github.com/googleapis/google-cloud-go/pull/9439/files |
trollyxia
force-pushed
the
authorized_view
branch
2 times, most recently
from
ee056e2
to
309c407
Compare
Done. |
trollyxia
force-pushed
the
authorized_view
branch
from
e2b3a13
to
72ebbe9
Compare
bhshkh
approved these changes
Mar 13, 2024
|
LGTM. Can be merged once vet failures are resolved |
trollyxia
force-pushed
the
authorized_view
branch
from
8d97b3a
to
4d35698
Compare
added 4 commits
March 13, 2024 17:05
Change-Id: I1c04c6abb7a0ecaaa5a95334b9e6934f638b5afb
Change-Id: Id22fe08bc0a830cab83f30d892f6d78c269d2895
Change-Id: I9781e0882f1b152228edb276f12284d5ccf64315
Change-Id: I5dc6c0c79067903fe5c71c0f9d51e40d3f5233ca
trollyxia
force-pushed
the
authorized_view
branch
from
4d35698
to
78f55b2
Compare
Change-Id: Ie1e82d3a8389d26217f0fc10ffa9ca16f3b72b6d
trollyxia
force-pushed
the
authorized_view
branch
2 times, most recently
from
137c23a
to
45c8fba
Compare
|
Please ignore conformance test failures. They were added in failed state |
trollyxia
force-pushed
the
authorized_view
branch
from
45c8fba
to
44d7411
Compare
Change-Id: Ia07847f4c43197d8498ead0e225651fe2b4713d7
trollyxia
force-pushed
the
authorized_view
branch
from
44d7411
to
0fb3604
Compare
mutianf
approved these changes
Mar 18, 2024
igorbernstein2
requested changes
Mar 22, 2024
trollyxia
force-pushed
the
authorized_view
branch
from
9fabb83
to
36b5da3
Compare
Change-Id: I99f87a46cd96d96710aac4532a61361dcc7e2a27
trollyxia
force-pushed
the
authorized_view
branch
from
36b5da3
to
8ff051b
Compare
igorbernstein2
requested changes
Mar 27, 2024
Change-Id: I974abdf400050d65b76a2fed34685e20d2e7781f
Change-Id: I28880079e167d37cad1fc6740c089e51be10f347
igorbernstein2
approved these changes
Apr 26, 2024
bhshkh
approved these changes
Apr 26, 2024
ma-g-22
pushed a commit
to ma-g-22/google-cloud-go
that referenced
this pull request
Apr 29, 2024
…leapis#9515) * feat(bigtable): Support AuthorizedView in data and admin client Change-Id: I1c04c6abb7a0ecaaa5a95334b9e6934f638b5afb * fix: Address review comments Change-Id: Id22fe08bc0a830cab83f30d892f6d78c269d2895 * feat: Add AuthorizedView IAM Change-Id: I9781e0882f1b152228edb276f12284d5ccf64315 * fix: fix request headers for AuthorizedViews Change-Id: I5dc6c0c79067903fe5c71c0f9d51e40d3f5233ca * fix: resolve vet failures Change-Id: Ie1e82d3a8389d26217f0fc10ffa9ca16f3b72b6d * Expose FamilySubset struct and a small fix Change-Id: Ia07847f4c43197d8498ead0e225651fe2b4713d7 * Address review comments Change-Id: I99f87a46cd96d96710aac4532a61361dcc7e2a27 * Let Get method return Info struct and reordering Change-Id: I974abdf400050d65b76a2fed34685e20d2e7781f * fix: Remove GetSubsetView() and reordering Change-Id: I28880079e167d37cad1fc6740c089e51be10f347 --------- Co-authored-by: trollyxia <lixiachen@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds AuthorizedView admin CRUD methods, and allows existing data methods to work with an AuthorizedView.
Change-Id: I1c04c6abb7a0ecaaa5a95334b9e6934f638b5afb