Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(internal/godocfx): Use default html rendering #6802

Merged
merged 2 commits into from Oct 3, 2022

Conversation

tbpg
Copy link
Contributor

@tbpg tbpg commented Oct 3, 2022

The previous setup was rendering doc headings as H1s. Now that the default GoDoc supports links and lists, we can use it directly.

As a result, we can delete the third_party copy of the go/doc package and the custom goldmark plugin.

ToMarkdown was added in #3816.

The previous setup was rendering doc headings as H1s. Now that the
default GoDoc supports links and lists, we can use it directly.

As a result, we can delete the third_party copy of the go/doc package
and the custom goldmark plugin.
@tbpg tbpg requested a review from a team as a code owner October 3, 2022 17:07
@product-auto-label product-auto-label bot added the size: xl Pull request size is extra large. label Oct 3, 2022
@tbpg tbpg requested a review from codyoss October 3, 2022 17:22
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@codyoss codyoss added the automerge Merge the pull request once unit tests and other checks pass. label Oct 3, 2022
@gcf-merge-on-green gcf-merge-on-green bot merged commit ec2ad2f into main Oct 3, 2022
@gcf-merge-on-green gcf-merge-on-green bot deleted the godocfx-headers branch October 3, 2022 20:54
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: xl Pull request size is extra large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants