Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(storage): add retry config to ACL handle methods #5185

Merged
merged 7 commits into from Dec 9, 2021
Merged

feat(storage): add retry config to ACL handle methods #5185

merged 7 commits into from Dec 9, 2021

Conversation

BrennaEpp
Copy link
Contributor

@BrennaEpp BrennaEpp commented Dec 3, 2021 •
edited

  • Adds retryConfig to ACLs when set on a bucket or object handle
    BEGIN_COMMIT_OVERRIDE
    END_COMMIT_OVERRIDE

@BrennaEpp BrennaEpp requested review from a team as code owners December 3, 2021 19:29
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 3, 2021
@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Dec 3, 2021
@BrennaEpp BrennaEpp mentioned this pull request Dec 6, 2021
Merged
tritone
tritone reviewed Dec 7, 2021
View reviewed changes
Copy link
Contributor

@tritone tritone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good, just need to finish extending the retry wrapper to the remaining ACLHandle methods.

storage/storage_test.go
},
}
for _, ac := range configHandleCases {
s.Run(ac.name, func(ss *testing.T) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't realize these could be nested... nice!

storage/acl.go Show resolved Hide resolved
@BrennaEpp BrennaEpp merged commit be07d8d into googleapis:main Dec 9, 2021
@BrennaEpp BrennaEpp deleted the acl-retry branch December 9, 2021 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tritone tritone tritone approved these changes

Assignees
No one assigned
Labels
api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@BrennaEpp @tritone