New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(storage): post policy can be signed with a fn that takes raw bytes #5079
Merged
BrennaEpp
merged 16 commits into
googleapis:main
from
BrennaEpp:storage-sign-post-policy
Nov 9, 2021
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
31cc7d7
example
codyoss e2739e4
add test and comments
BrennaEpp 65d5d50
change name
BrennaEpp 097840e
Merge branch 'master' into storage-sign-post-policy
BrennaEpp 0193cdd
Merge branch 'master' into storage-sign-post-policy
BrennaEpp 9606c91
example
BrennaEpp f5d5002
Merge branch 'master' into storage-sign-post-policy
BrennaEpp cf23063
Merge branch 'master' into storage-sign-post-policy
BrennaEpp 3e59217
Merge branch 'master' into storage-sign-post-policy
BrennaEpp 2d387aa
change obj name
BrennaEpp 879652c
add comment
BrennaEpp 63e5a18
add comment on function working w signbutes/signrawbytes
BrennaEpp a562c83
add unexported field
BrennaEpp c4960c2
Merge branch 'main' into storage-sign-post-policy
BrennaEpp 64c59ff
add comment
BrennaEpp 940ecfd
Merge branch 'main' into storage-sign-post-policy
BrennaEpp File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't think passing
StatusCodeOnSuccess
is necessary; it should always be 200 right?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It can be different depending on what you specify in
PostPolicyV4Options.PolicyV4Fields.StatusCodeOnSuccess
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think currently it is 200 in all these tests, so we shouldn't pass more params unnecessarily if possible.