Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pubsublite): disable grpc stream retries #5019

Merged
merged 2 commits into from Oct 26, 2021
Merged

fix(pubsublite): disable grpc stream retries #5019

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a45d61
fix(pubsublite): disable grpc stream retries
tmdiep Oct 22, 2021
fb6f051
Merge branch 'master' into disable_stream_retries
tmdiep Oct 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 7 additions & 3 deletions pubsublite/internal/wire/rpc.go
View file
Open in desktop
Expand Up @@ -193,9 +193,13 @@ func defaultClientOptions(region string) []option.ClientOption {
}

func streamClientOptions(region string) []option.ClientOption {
// To ensure most users don't hit the limit of 100 streams per connection, if
// they have a high number of topic partitions.
return append(defaultClientOptions(region), option.WithGRPCConnectionPool(8))
return append(defaultClientOptions(region),
// To ensure most users don't hit the limit of 100 streams per connection, if
// they have a high number of topic partitions.
option.WithGRPCConnectionPool(8),
// Stream reconnections must be handled here in order to reinitialize state,
// rather than in grpc-go.
option.WithGRPCDialOption(grpc.WithDisableRetry()))
}

// NewAdminClient creates a new gapic AdminClient for a region.
Expand Down