Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(storage): add rpo (turbo replication) support #5003
feat(storage): add rpo (turbo replication) support #5003
Changes from 2 commits
b78571b
bb23239
e9ec13d
5075749
efb0f00
40aee10
12c2a68
567f8d6
4b04744
621dabe
3f19e71
b0a1c37
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can RPO be set to default? If so, I think we'd need another unknown-type value to be the zero value. Zeros do not propagate through to the service generally. And I think we'd want to distinguish in bucket attrs between
DEFAULT
vs. an unknown value (if there is a new enum addition) and/or nothing being returned for that field.See what I have for PublicAccessPrevention, I'm assuming this should probably operate the same way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just for some clarity, in the case of a single region bucket, RPO will not be present in the metadata. For a multiregion bucket, RPO will always come back as DEFAULT.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good note, I've changed this as suggested.