Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(storage): don't assume auth from a client option #4982

Merged
merged 3 commits into from Oct 14, 2021
Merged

fix(storage): don't assume auth from a client option #4982

merged 3 commits into from Oct 14, 2021

Commits on Oct 13, 2021

  1. fix(storage): don't assume auth from a client option 

    There are cases where a user might not auth with ADC or a client
option such as passing in their own client. In these cases we
should not error, but instead just not make use of the internal
cred lookup.

Fixes: #4980
    @codyoss
    codyoss committed Oct 13, 2021
    Copy the full SHA
    7ad5ac4 View commit details
    Browse the repository at this point in the history

  2. switch ordering of some lines

    @codyoss
    codyoss committed Oct 13, 2021
    Copy the full SHA
    c6189e3 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2021

  1. add some docs

    @codyoss
    codyoss committed Oct 14, 2021
    Copy the full SHA
    45f309c View commit details
    Browse the repository at this point in the history