test(pubsub): make config checks specific to field #4956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I5f6c3098464a214cbe8281417192bfa52122f21c
Change-Id: I2809bfaab6a2547c9fbc1ddb055359882262b544
Change-Id: Ie09da85759bc04be3867e4f6006cfcde12a41f34
google-cla
bot
added
the
cla: yes
…est-fix-config-checks Change-Id: I86d49a96cc22a8022acfc72a37f0bbc27b522286
Change-Id: Ifc79fba03ee13583fa97cffb28f2f439061a2b69
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered in #4953, many of our config equality checks (with testutil.Equal or testutil.Diff) are overly broad in comparisons. This was uncovered when adding an unexported field to Topic and SubscriptionConfigs, which causes these comparisons to fail. This can be mitigated using
cmpopts.IgnoreUnexported(TopicConfig{}), but is better addressed by making the tests check specifically against the field they are modifying.