docs(bigquery): use xerror.As with googleapi.Error #4814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix up type assertions with googleapi.Error to use xerrors.As. In bigquery, this was only required in integration tests and in the package docs. Follows from googleapis#4797 and similar to some of the fixes in storage in googleapis#4802 (storage required additional changes though).
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: bigquery
|
LGTM |
shollyman
approved these changes
Sep 27, 2021
tritone
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix up type assertions with googleapi.Error to use xerrors.As.
In bigquery, this was only required in integration tests and in
the package docs.
Follows from #4797 and similar to some of the fixes in storage
in #4802 (storage required additional changes though).