Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(internal): provide wrapping for retried errors #4797

Merged
merged 9 commits into from Sep 23, 2021
Merged

feat(internal): provide wrapping for retried errors #4797

merged 9 commits into from Sep 23, 2021

Commits on Sep 23, 2021

  1. feat: provide wrapped errors with context errors 

    Currently, if an operation is retried until it times out, we
give an error string that covers both the context error and
the service error. However, this was implemented before Go 1.13
error wrapping. With this change, the error string stays the same,
but we provide wrapping semantics so users can introspect context
errors and gRPC/HTTP errors from the returned error.
    @tritone
    tritone committed Sep 23, 2021
    Copy the full SHA
    0f3a15c View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into ctx-err-wrap

    @tritone
    tritone committed Sep 23, 2021
    Copy the full SHA
    5baffed View commit details
    Browse the repository at this point in the history

  3. fix gRPC status FromError

    @tritone
    tritone committed Sep 23, 2021
    Copy the full SHA
    a401d43 View commit details
    Browse the repository at this point in the history

  4. update nil gRPC error behavior

    @tritone
    tritone committed Sep 23, 2021
    Copy the full SHA
    2a99f7a View commit details
    Browse the repository at this point in the history

  5. gofmt

    @tritone
    tritone committed Sep 23, 2021
    Copy the full SHA
    5513f75 View commit details
    Browse the repository at this point in the history

  6. change cerr to ctxErr

    @tritone
    tritone committed Sep 23, 2021
    Copy the full SHA
    9d41285 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'master' into ctx-err-wrap

    @crwilcox
    crwilcox committed Sep 23, 2021
    Copy the full SHA
    67f7dde View commit details
    Browse the repository at this point in the history

  8. Merge branch 'master' into ctx-err-wrap

    @tritone
    tritone committed Sep 23, 2021
    Copy the full SHA
    8fd226c View commit details
    Browse the repository at this point in the history

  9. Merge branch 'master' into ctx-err-wrap

    @gcf-merge-on-green
    gcf-merge-on-green[bot] committed Sep 23, 2021
    Copy the full SHA
    3fb2ed1 View commit details
    Browse the repository at this point in the history