Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(spanner/spannertest): Support generated columns #4742

Merged
merged 17 commits into from Sep 20, 2021
Merged

feat(spanner/spannertest): Support generated columns #4742

merged 17 commits into from Sep 20, 2021

Commits on Sep 13, 2021

  1. feat(spanner/spannertest): Support generated columns

    @philwitty
    philwitty committed Sep 13, 2021
    Copy the full SHA
    d70a2fe View commit details
    Browse the repository at this point in the history

  2. Add support for LOWER function

    @philwitty
    philwitty committed Sep 13, 2021
    Copy the full SHA
    1469ccd View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2021

  1. Merge remote-tracking branch 'origin/master' into generated-columns

    @philwitty
    philwitty committed Sep 14, 2021
    Copy the full SHA
    8e160e7 View commit details
    Browse the repository at this point in the history

  2. Remove checking of dependent columns and improve testing

    @philwitty
    philwitty committed Sep 14, 2021
    Copy the full SHA
    d247e11 View commit details
    Browse the repository at this point in the history

  3. docs: fix a couple of comments

    @olavloite
    olavloite committed Sep 14, 2021
    Copy the full SHA
    023d966 View commit details
    Browse the repository at this point in the history

  4. Make CI happy with casing

    @philwitty
    philwitty committed Sep 14, 2021
    Copy the full SHA
    3babbb9 View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2021

  1. Don't panic if columns are nil in generated columns using funcs 

    * No longer returning code.InvalidArgument when calling db_eval.evalFunc
  but that seems consistent with the rest of the module, no tests failed
  so I assume its not behaviour relied upon, we could check for the
  error type instead
    @philwitty
    philwitty committed Sep 15, 2021
    Copy the full SHA
    d56eb3b View commit details
    Browse the repository at this point in the history

  2. Add ErrorIs and make functions public to allow spannertest to use

    @philwitty
    philwitty committed Sep 15, 2021
    Copy the full SHA
    af15328 View commit details
    Browse the repository at this point in the history

  3. fix: add errorIs to spannertest package

    @olavloite
    olavloite committed Sep 15, 2021
    Copy the full SHA
    f55835d View commit details
    Browse the repository at this point in the history

  4. fix: remove unrelated changes

    @olavloite
    olavloite committed Sep 15, 2021
    Copy the full SHA
    8f53cad View commit details
    Browse the repository at this point in the history

  5. fix: remove specific error checking and return null from evaluations

    @olavloite
    olavloite committed Sep 15, 2021
    Copy the full SHA
    e3c82c2 View commit details
    Browse the repository at this point in the history

  6. fix: restore to original errors

    @olavloite
    olavloite committed Sep 15, 2021
    Copy the full SHA
    2bf349c View commit details
    Browse the repository at this point in the history

  7. Merge branch 'master' into generated-columns

    @olavloite
    olavloite committed Sep 15, 2021
    Copy the full SHA
    1c9fe2c View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2021

  1. Prettify comments

    @philwitty
    philwitty committed Sep 17, 2021
    Copy the full SHA
    03d80d3 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2021

  1. test: add error msg + delete test

    @olavloite
    olavloite committed Sep 20, 2021
    Copy the full SHA
    d33754c View commit details
    Browse the repository at this point in the history

  2. Merge branch 'generated-columns' of github.com:psytale/google-cloud-g… 

    …o into generated-columns
    @olavloite
    olavloite committed Sep 20, 2021
    Copy the full SHA
    e04ef36 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into generated-columns

    @olavloite
    olavloite committed Sep 20, 2021
    Copy the full SHA
    99a8c91 View commit details
    Browse the repository at this point in the history