Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storage): align retry idempotency (part 1) #4715

Merged
merged 2 commits into from Sep 2, 2021

Commits on Sep 2, 2021

  1. fix(storage): align retry idempotency (part 1)

    Certain non-idempotent operations were being retried by the
    library, and certain idempotent operations were not. This
    fixes the following operations:
    
    Add retry: notifications.delete, service_account.get
    Remove retry: bucket_acl.delete, bucket_acl.update,
      default_object_acl.delete, default_object_acl.update,
      object_acl.delete, object_acl.update, hmacKey.create
    
    Additional PR on conditionally idempotent operations to come.
    tritone committed Sep 2, 2021
    Copy the full SHA
    6445274 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    f61f522 View commit details
    Browse the repository at this point in the history