Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(spanner/spannertest): Fix the "LIKE" clause handling for forward and backward matches #4655

Merged
merged 2 commits into from Aug 23, 2021
Merged

fix(spanner/spannertest): Fix the "LIKE" clause handling for forward and backward matches #4655

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e18e2c0
fix(spannertest): Fix the "LIKE" clause handling for prefix and suffi…
sryoya Aug 20, 2021
500f5bd
Merge branch 'master' into fix_LIKE_clause_handling_for_prefix_and_su…
olavloite Aug 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions spanner/spannertest/db_eval.go
View file
Open in desktop
Expand Up @@ -873,6 +873,12 @@ func evalLike(str, pat string) bool {

// Lean on regexp for simplicity.
pat = regexp.QuoteMeta(pat)
if !strings.HasPrefix(pat, "%") {
pat = "^" + pat
}
if !strings.HasSuffix(pat, "%") {
pat = pat + "$"
}
pat = strings.Replace(pat, "%", ".*", -1)
pat = strings.Replace(pat, "_", ".", -1)
match, err := regexp.MatchString(pat, str)
Expand Down
15 changes: 15 additions & 0 deletions spanner/spannertest/integration_test.go
View file
Open in desktop
Expand Up @@ -816,6 +816,21 @@ func TestIntegration_ReadsAndQueries(t *testing.T) {
{"Jack", 1.85},
},
},
{
`SELECT str FROM SomeStrings WHERE str LIKE "a%"`,
nil,
[][]interface{}{
{"afoo"},
{"abar"},
},
},
{
`SELECT Name FROM Staff WHERE Name LIKE "%e"`,
nil,
[][]interface{}{
{"George"},
},
},
{
`SELECT Name FROM Staff WHERE Name LIKE "J%k" OR Name LIKE "_am"`,
nil,
Expand Down